feat(storage): Create OTel tracing decorator for Client::DownloadToFile()#15283
Merged
shubham-up-47 merged 9 commits intoAug 12, 2025
Merged
Conversation
shubham-up-47
changed the title
Client::DownloadToFile()
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15283 +/- ##
=======================================
Coverage 93.01% 93.01%
=======================================
Files 2403 2403
Lines 219066 219107 +41
=======================================
+ Hits 203761 203805 +44
+ Misses 15305 15302 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
product-auto-label
Bot
added
the
api: storage
shubham-up-47
assigned
bajajneha27 and
scotthart and unassigned
bajajneha27 and
scotthart
bajajneha27
previously approved these changes
Jul 24, 2025
scotthart
previously approved these changes
Jul 24, 2025
Member
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewed 6 of 9 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @shubham-up-47)
shubham-up-47
dismissed stale reviews from scotthart and bajajneha27
via
4522480
Contributor
Author
|
/gcbrun |
bajajneha27
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the implementation logic of private method DownloadFileImpl from client.cc file to connection_impl.cc file, so that tracing of
client::DownloadToFilecan be enabled (#12907).Trace screenshot: https://screenshot.googleplex.com/78RD5T4DWAGeEcZ
Reference implementation: #15245
This change is