impl(v3): switch GCS to use GUAC#15890
impl(v3): switch GCS to use GUAC#15890scotthart merged 4 commits intogoogleapis:prepare-for-v3.0.0from
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes the transition of the Google Cloud Storage client library's authentication mechanism from its legacy GCS-specific OAuth2 implementation to the unified Google Unified Authentication Client (GUAC) API. This change simplifies the authentication codebase, removes deprecated components, and aligns GCS with a more consistent and modern authentication strategy across Google Cloud client libraries. The migration guide and various tests have been updated to reflect these significant internal changes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a significant and valuable refactoring that switches the GCS client to use the unified authentication client (GUAC), decommissioning the GCS-specific OAuth2 API. This aligns the GCS client with other C++ client libraries and simplifies the codebase by removing a lot of deprecated code. The changes correctly update client construction, authentication logic in tests and benchmarks, and the v3 migration guide. My review found a few typos in the code examples within the migration guide, for which I've provided suggestions. Overall, the changes are well-executed and improve the maintainability of the library.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15890 +/- ##
======================================================
- Coverage 92.84% 92.82% -0.02%
======================================================
Files 2391 2360 -31
Lines 218505 216610 -1895
======================================================
- Hits 202881 201079 -1802
+ Misses 15624 15531 -93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d62b07f to
0991429
Compare
69724ae
into
googleapis:prepare-for-v3.0.0
This is second (and hopefully last PR to decommission the GCS specific OAuth2 API and use the GUAC API instead.
This PR: