impl(v3): add bespoke WaitForConsistency to bigtable table admin

[scotthart]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new WaitForConsistency method to the Bigtable Table Admin client library. This method provides a higher-level abstraction for ensuring data consistency across Bigtable tables by internally managing the polling and retry logic for CheckConsistency operations. This enhancement simplifies client-side code that needs to wait for replication to catch up after data modifications, improving usability and reducing boilerplate.

Highlights

• New WaitForConsistency Method: Introduced a new WaitForConsistency method in the BigtableTableAdminClient to simplify polling for table consistency based on a provided token.
• Bespoke Method Implementation: The WaitForConsistency method is implemented as a bespoke method, utilizing an AsyncRetryLoop to repeatedly call AsyncCheckConsistency until the table is consistent or the retry policy is exhausted.
• Updated Examples and Tests: The table_admin_snippets.cc example and admin_integration_test.cc have been updated to demonstrate and verify the usage of the new WaitForConsistency method, ensuring proper functionality and integration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a bespoke WaitForConsistency method to the Bigtable table admin client. The implementation correctly uses AsyncRetryLoop with a custom predicate to poll for consistency. The changes are consistently applied across the client, connection, and stub layers. The associated example and integration test have been updated to reflect and validate this new functionality. The integration test also correctly migrates from the older TableAdmin client to the newer v3 bigtable_admin::BigtableTableAdminClient.

My review includes a couple of suggestions for minor cleanups in the example code and the implementation of the retry predicate to improve code clarity.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.85%. Comparing base (74e98fc) to head (b474e15).
⚠️ Report is 2 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15917      +/-   ##
======================================================
- Coverage               92.85%   92.85%   -0.01%     
======================================================
  Files                    2343     2343              
  Lines                  216214   216218       +4     
======================================================
+ Hits                   200773   200776       +3     
- Misses                  15441    15442       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.