feat(storage): Add read chunkwise checksum validation for sync grpc read#16107
feat(storage): Add read chunkwise checksum validation for sync grpc read#16107v-pratap wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements CRC32C checksum validation for gRPC object reads by integrating a hash function into GrpcObjectReadSource. It updates the response handling to track offsets and validate data integrity during streaming. A new test case was added to verify behavior on checksum mismatches. Feedback suggests adding a defensive null check for the hash_function in the GrpcObjectReadSource constructor to prevent potential crashes if an explicit null is provided.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16107 +/- ##
========================================
Coverage 92.70% 92.71%
========================================
Files 2353 2353
Lines 218888 218986 +98
========================================
+ Hits 202925 203025 +100
+ Misses 15963 15961 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.