Skip to content

feat(storage): Add read chunkwise checksum validation for sync grpc read#16107

Open
v-pratap wants to merge 3 commits into
googleapis:mainfrom
v-pratap:read-checksum-1
Open

feat(storage): Add read chunkwise checksum validation for sync grpc read#16107
v-pratap wants to merge 3 commits into
googleapis:mainfrom
v-pratap:read-checksum-1

Conversation

@v-pratap
Copy link
Copy Markdown
Contributor

No description provided.

@v-pratap v-pratap requested review from a team as code owners May 19, 2026 15:33
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label May 19, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements CRC32C checksum validation for gRPC object reads by integrating a hash function into GrpcObjectReadSource. It updates the response handling to track offsets and validate data integrity during streaming. A new test case was added to verify behavior on checksum mismatches. Feedback suggests adding a defensive null check for the hash_function in the GrpcObjectReadSource constructor to prevent potential crashes if an explicit null is provided.

Comment thread google/cloud/storage/internal/grpc/object_read_source.cc Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.71%. Comparing base (3b37d40) to head (6d39f62).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #16107    +/-   ##
========================================
  Coverage   92.70%   92.71%            
========================================
  Files        2353     2353            
  Lines      218888   218986    +98     
========================================
+ Hits       202925   203025   +100     
+ Misses      15963    15961     -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread google/cloud/storage/internal/grpc/object_read_source.cc Outdated
Comment thread google/cloud/storage/internal/grpc/object_read_source.cc
Comment thread google/cloud/storage/internal/grpc/object_read_source.cc
@v-pratap v-pratap requested a review from kalragauri May 21, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants