feat(storage): remove deprecated legacy checksum options completely - #16279
feat(storage): remove deprecated legacy checksum options completely#16279v-pratap wants to merge 15 commits into
Conversation
…d option, remove unused Request parameter from ChecksumHelpers
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated DisableMD5Hash and DisableCrc32cChecksum options, replacing them with UploadChecksumValidationOption and DownloadChecksumValidationOption across the codebase, including tests and benchmarks. The review feedback highlights several style guide violations, such as lines exceeding the 80-character limit, excessive blank lines, and a broken Doxygen comment block. Additionally, it is recommended to factor out a repeated nested ternary expression in throughput_experiment.cc into a helper function to reduce duplication and improve readability.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16279 +/- ##
==========================================
- Coverage 92.30% 92.30% -0.01%
==========================================
Files 2223 2223
Lines 208086 207899 -187
==========================================
- Hits 192074 191893 -181
+ Misses 16012 16006 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ff1c503 to
92a3ed7
Compare
1 participant
This PR removes the deprecated
DisableMD5HashandDisableCrc32cChecksumcompletely from the codebase as requested for the next major release. This includes:hashing_options.h).UploadChecksumValidationOptionandDownloadChecksumValidationOption.This also includes the missing checksum options migrations from
parallel_upload.hand the benchmarks.