Skip to content

impl: add gRPC PQC test - #16282

Merged
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:pqc_grpc_test
Jul 29, 2026
Merged

impl: add gRPC PQC test#16282
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:pqc_grpc_test

Conversation

@scotthart

Copy link
Copy Markdown
Member

Verifies MLKEM algorithms are being used with gRPC transport.

@scotthart
scotthart requested a review from a team as a code owner July 28, 2026 16:30

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new gRPC integration test to verify Post-Quantum Cryptography (PQC) using the X25519MLKEM768 group, alongside updates to the Bazel build configuration and the showcase test runner. It also refactors existing assertions in the REST PQC test to use modern GoogleTest/GoogleMock matchers. The review feedback highlights a potential undefined behavior issue in the new gRPC test when constructing std::string from potentially empty grpc::string_ref metadata keys or values, and suggests a safe extraction helper.

Comment thread ci/showcase/grpc_pqc_test.cc
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.30%. Comparing base (a72ba49) to head (9c4d070).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16282   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files        2223     2223           
  Lines      207876   207876           
=======================================
+ Hits       191876   191883    +7     
+ Misses      16000    15993    -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart

Copy link
Copy Markdown
Member Author

/gcbrun

@scotthart
scotthart merged commit 446f6c8 into googleapis:main Jul 29, 2026
105 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants