Skip to content

ci: otel_collector updates #16284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotthart merged 2 commits into from
Jul 29, 2026
+10 −3
Merged

ci: otel_collector updates #16284

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538a216
ci: otel_collector updates
scotthart Jul 28, 2026
a9bd631
address review comments
scotthart Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/otel_collector/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ cc_library(
srcs = ["otel_collector.cc"],
hdrs = ["otel_collector.h"],
deps = [
"//:common",
"//protos/google/cloud/opentelemetry/testing:observability_verification_cc_grpc",
"//protos/google/cloud/opentelemetry/testing:observability_verification_cc_proto",
"@googleapis//google/monitoring/v3:monitoring_cc_grpc",
Expand Down
8 changes: 5 additions & 3 deletions ci/otel_collector/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@ add_library(otel_collector otel_collector.cc otel_collector.h)
target_link_libraries(
otel_collector PUBLIC google_cloud_cpp_opentelemetry_testing_protos
google-cloud-cpp::monitoring_protos gRPC::grpc++)
target_include_directories(otel_collector PUBLIC ${PROJECT_SOURCE_DIR})
add_dependencies(otel_collector google_cloud_cpp_opentelemetry_testing_protos)
Comment thread
scotthart marked this conversation as resolved.
Outdated
target_include_directories(otel_collector PUBLIC ${PROJECT_SOURCE_DIR}
${PROJECT_BINARY_DIR})
google_cloud_cpp_add_common_options(otel_collector NO_WARNINGS)

google_cloud_cpp_add_executable(target "otel_collector_main"
"otel_collector_main.cc")
target_link_libraries(otel_collector_main PRIVATE otel_collector gRPC::grpc++)
google_cloud_cpp_add_common_options(otel_collector_main NO_WARNINGS)
target_link_libraries(${target} PRIVATE otel_collector gRPC::grpc++)
google_cloud_cpp_add_common_options(${target} NO_WARNINGS)
2 changes: 2 additions & 0 deletions ci/otel_collector/otel_collector.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

namespace google {
namespace cloud {
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
namespace testing_util {

grpc::Status OtelCollectorServer::CreateTimeSeries(
Expand Down Expand Up @@ -68,5 +69,6 @@ void OtelCollectorServer::Clear() {
}

} // namespace testing_util
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google
3 changes: 3 additions & 0 deletions ci/otel_collector/otel_collector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#ifndef GOOGLE_CLOUD_CPP_CI_OTEL_COLLECTOR_OTEL_COLLECTOR_H
#define GOOGLE_CLOUD_CPP_CI_OTEL_COLLECTOR_OTEL_COLLECTOR_H

#include "google/cloud/version.h"
#include "protos/google/cloud/opentelemetry/testing/observability_verification.grpc.pb.h"
#include <google/monitoring/v3/metric_service.grpc.pb.h>
#include <grpcpp/grpcpp.h>
Expand All @@ -23,6 +24,7 @@

namespace google {
namespace cloud {
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
namespace testing_util {

/**
Expand Down Expand Up @@ -71,6 +73,7 @@ class OtelCollectorServer final
};

} // namespace testing_util
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace cloud
} // namespace google

Expand Down
Loading