Skip to content

Commit 361aff2

Browse files
perf(Storage): Optimize CRC32C interceptor with ReferenceEquals check for uploadUri
This change introduces a ReferenceEquals check for the _uploadUri. Since URI objects are typically stable during the request lifecycle, this provides an O(1) fast-path to bypass the interceptor logic for unrelated traffic, minimizing service-wide latency. - Added ReferenceEquals check for immediate filtering - Reduced CPU cycles for non-upload service calls - Addressed PR feedback regarding parallel request overhead
1 parent fbbe491 commit 361aff2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/CustomMediaUpload.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public Crc32cHashInterceptor(CustomMediaUpload mediaUpload, HashingStream hashin
6868

6969
public Task InterceptAsync(HttpRequestMessage request, CancellationToken cancellationToken)
7070
{
71-
if (_uploadUri == null || !_uploadUri.Equals(request.RequestUri))
71+
if (_uploadUri == null || (!ReferenceEquals(_uploadUri, request.RequestUri) && !_uploadUri.Equals(request.RequestUri)))
7272
{
7373
return Task.CompletedTask;
7474
}

0 commit comments

Comments
 (0)