Skip to content

Commit 126105a

Browse files
hongalexwestarle
authored andcommitted
test(bigquery): unskip trace test and bump gax-go
1 parent 46df848 commit 126105a

5 files changed

Lines changed: 6 additions & 7 deletions

File tree

bigquery/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ require (
1111
github.com/apache/arrow/go/v15 v15.0.2
1212
github.com/google/go-cmp v0.7.0
1313
github.com/google/uuid v1.6.0
14-
github.com/googleapis/gax-go/v2 v2.20.0
14+
github.com/googleapis/gax-go/v2 v2.21.0
1515
go.opencensus.io v0.24.0
1616
go.opentelemetry.io/otel v1.42.0
1717
go.opentelemetry.io/otel/sdk v1.42.0

bigquery/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
105105
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
106106
github.com/googleapis/enterprise-certificate-proxy v0.3.14 h1:yh8ncqsbUY4shRD5dA6RlzjJaT4hi3kII+zYw8wmLb8=
107107
github.com/googleapis/enterprise-certificate-proxy v0.3.14/go.mod h1:vqVt9yG9480NtzREnTlmGSBmFrA+bzb0yl0TxoBQXOg=
108-
github.com/googleapis/gax-go/v2 v2.20.0 h1:NIKVuLhDlIV74muWlsMM4CcQZqN6JJ20Qcxd9YMuYcs=
109-
github.com/googleapis/gax-go/v2 v2.20.0/go.mod h1:But/NJU6TnZsrLai/xBAQLLz+Hc7fHZJt/hsCz3Fih4=
108+
github.com/googleapis/gax-go/v2 v2.21.0 h1:h45NjjzEO3faG9Lg/cFrBh2PgegVVgzqKzuZl/wMbiI=
109+
github.com/googleapis/gax-go/v2 v2.21.0/go.mod h1:But/NJU6TnZsrLai/xBAQLLz+Hc7fHZJt/hsCz3Fih4=
110110
github.com/klauspost/compress v1.16.7 h1:2mk3MPGNzKyxErAw8YaohYh69+pa4sIQSC0fPGCFR9I=
111111
github.com/klauspost/compress v1.16.7/go.mod h1:ntbaceVETuRiXiv4DpjP66DpAtAGkEQskQzEyD//IeE=
112112
github.com/klauspost/cpuid/v2 v2.2.5 h1:0E5MSMDEoAulmXNFquVs//DdoomxaoTY1kUhbc/qbZg=

bigquery/trace_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ func TestSetDatasetTraceMetadata(t *testing.T) {
6161
}
6262

6363
func TestTracingTelemetryAttributes(t *testing.T) {
64-
t.Skip("Skipping flaky test pending auth module release: https://github.com/googleapis/google-cloud-go/issues/14205")
6564
os.Setenv("GOOGLE_SDK_GO_EXPERIMENTAL_TRACING", "true")
6665
defer os.Unsetenv("GOOGLE_SDK_GO_EXPERIMENTAL_TRACING")
6766
gax.TestOnlyResetIsFeatureEnabled()

pubsublite/internal/wire/settings_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func TestValidatePublishSettings(t *testing.T) {
3838
// These have no max bounds, check large values.
3939
settings.DelayThreshold = 24 * time.Hour
4040
settings.Timeout = 24 * time.Hour
41-
settings.BufferedByteLimit = 1e10
41+
settings.BufferedByteLimit = 1e9
4242
},
4343
wantErr: false,
4444
},
@@ -133,7 +133,7 @@ func TestValidateReceiveSettings(t *testing.T) {
133133
settings.Partitions = []int{5, 3, 9, 1, 4, 0}
134134
// These have no max bounds, check large values.
135135
settings.MaxOutstandingMessages = 100000
136-
settings.MaxOutstandingBytes = 1e10
136+
settings.MaxOutstandingBytes = 1e9
137137
settings.Timeout = 24 * time.Hour
138138
},
139139
wantErr: false,

pubsublite/pscompat/settings.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ var DefaultPublishSettings = PublishSettings{
122122
CountThreshold: 100,
123123
ByteThreshold: 1e6,
124124
Timeout: 7 * 24 * time.Hour,
125-
BufferedByteLimit: 1e10,
125+
BufferedByteLimit: 1e9,
126126
EnableIdempotence: true,
127127
}
128128

0 commit comments

Comments
 (0)