File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -3373,6 +3373,7 @@ func TestGRPCRetryReadStallEmulated(t *testing.T) {
33733373 t .Fatalf ("storage.NewGRPCClient: %v" , err )
33743374 }
33753375 defer client .Close ()
3376+ client .SetRetry (WithBackoff (gax.Backoff {Initial : 10 * time .Millisecond }))
33763377
33773378 project := "fake-project"
33783379 bucket := fmt .Sprintf ("grpc-bucket-%d" , time .Now ().Nanosecond ())
Original file line number Diff line number Diff line change @@ -250,12 +250,6 @@ func (w *withTestMetricReaderConfig) ApplyStorageOpt(c *storageConfig) {
250250//
251251// This is supported for read operations on HTTP (XML) and gRPC clients (not implemented for HTTP JSON client).
252252func withReadStallTimeout (rstc * experimental.ReadStallTimeoutConfig ) option.ClientOption {
253- // TODO (raj-prince): To keep separate dynamicDelay instance for different BucketHandle.
254- // Currently, dynamicTimeout is kept at the client and hence shared across all the
255- // BucketHandle, which is not the ideal state. As latency depends on location of VM
256- // and Bucket, and read latency of different buckets may lie in different range.
257- // Hence having a separate dynamicTimeout instance at BucketHandle level will
258- // be better
259253 if rstc .Min == time .Duration (0 ) {
260254 rstc .Min = defaultDynamicReadReqMinTimeout
261255 }
You can’t perform that action at this time.
0 commit comments