Skip to content

Commit 5baec6d

Browse files
committed
resolving merge conflict
1 parent 9c8589c commit 5baec6d

2 files changed

Lines changed: 1 addition & 6 deletions

File tree

storage/client_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3373,6 +3373,7 @@ func TestGRPCRetryReadStallEmulated(t *testing.T) {
33733373
t.Fatalf("storage.NewGRPCClient: %v", err)
33743374
}
33753375
defer client.Close()
3376+
client.SetRetry(WithBackoff(gax.Backoff{Initial: 10 * time.Millisecond}))
33763377

33773378
project := "fake-project"
33783379
bucket := fmt.Sprintf("grpc-bucket-%d", time.Now().Nanosecond())

storage/option.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -250,12 +250,6 @@ func (w *withTestMetricReaderConfig) ApplyStorageOpt(c *storageConfig) {
250250
//
251251
// This is supported for read operations on HTTP (XML) and gRPC clients (not implemented for HTTP JSON client).
252252
func withReadStallTimeout(rstc *experimental.ReadStallTimeoutConfig) option.ClientOption {
253-
// TODO (raj-prince): To keep separate dynamicDelay instance for different BucketHandle.
254-
// Currently, dynamicTimeout is kept at the client and hence shared across all the
255-
// BucketHandle, which is not the ideal state. As latency depends on location of VM
256-
// and Bucket, and read latency of different buckets may lie in different range.
257-
// Hence having a separate dynamicTimeout instance at BucketHandle level will
258-
// be better
259253
if rstc.Min == time.Duration(0) {
260254
rstc.Min = defaultDynamicReadReqMinTimeout
261255
}

0 commit comments

Comments
 (0)