fix(spanner/spannertest): Support UUID as a base data type#14117
fix(spanner/spannertest): Support UUID as a base data type#14117adamhicks wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for the UUID data type in spansql, fixing an issue where the type was being mangled during parsing and serialization. The changes correctly introduce UUID as a base type, update the parser and SQL generator, and add corresponding tests. The existing comment in spanner/spannertest/funcs.go has been kept as it provides valid feedback for code clarity and consistency.
|
@rahul2393 sorry for the ping, but you reviewed this last year. Would you mind taking a look at this PR? |
|
@rahul2393 @quartzmo are either of you able to review this PR? Or able to tag someone else who may be able to help? |
|
Are there any updates available on this PR and when a review is possible? |
|
@sakthivelmanii can you please help with second review. |
Currently if we have this ddl statement
and we run it through
spansqllike this:we end up with
which can no longer be run against the database as the UUID data type has been mangled.
This change proposes to add UUID as a base type so that it can be recognised and retained through parsing.