feat(firestore): refine Pipelines API, error handling, and tests#14429
Merged
Conversation
product-auto-label
Bot
added
the
api: firestore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the reliability of Firestore integration tests by standardizing resource cleanup using t.Cleanup and ensuring clients and bulk writers are properly closed. It also introduces named errors for pipeline execution, enables the ArrayFilter expression, and refines the ArraySlice and TimestampTruncateWithTimezone APIs. Feedback identifies a naming inconsistency with the Java SDK regarding array slicing, points out redundant cleanup registrations in tests, and suggests removing commented-out code and improving internal error messages for better clarity.
bhshkh
force-pushed
the
fspq-minor-fixes
branch
from
3e9884e to
bd75ed6
Compare
shollyman
reviewed
Apr 14, 2026
| // ErrPipelineWithoutDatabase is returned when a pipeline is executed without a database such as a subcollection pipeline. | ||
| ErrPipelineWithoutDatabase = errors.New("firestore: pipeline without a database cannot be executed directly, only as part of another pipeline") | ||
| // ErrUnionNotSupportRelativeScope is returned when a union is used with a relative scope pipeline. | ||
| ErrUnionNotSupportRelativeScope = errors.New("firestore: union only supports combining root pipelines; relative scope pipelines (like subcollection pipelines) are not supported") |
Contributor
There was a problem hiding this comment.
nit: maybe some naming improvement here? ErrRelativeScopeUnionUnsupported or something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several refinements to the Firestore Pipelines experimental feature, aimed at improving API consistency, error reporting, and the reliability of integration tests.
Key Changes: