feat: Enhance LoggingTracer with exception details and reuse getResponseAttributes

Author: blakeli0

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/LoggingTracer.java

@@ -77,16 +77,14 @@ void recordActionableError(Throwable error) {
     }
 
     Map<String, Object> logContext = new HashMap<>(apiTracerContext.getAttemptAttributes());
+    logContext.putAll(ObservabilityUtils.getResponseAttributes(error, apiTracerContext.transport()));
 
-    logContext.put(
-        ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE,
-        ObservabilityUtils.extractStatus(error).toString());
+    if (error != null && error.getMessage() != null) {
+      logContext.put("exception.message", error.getMessage());
+    }
 
     ErrorInfo errorInfo = ObservabilityUtils.extractErrorInfo(error);
     if (errorInfo != null) {
-      if (errorInfo.getReason() != null && !errorInfo.getReason().isEmpty()) {
-        logContext.put(ObservabilityAttributes.ERROR_TYPE_ATTRIBUTE, errorInfo.getReason());
-      }
       if (errorInfo.getDomain() != null && !errorInfo.getDomain().isEmpty()) {
         logContext.put(ObservabilityAttributes.ERROR_DOMAIN_ATTRIBUTE, errorInfo.getDomain());
       }

sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/LoggingTracerTest.java

@@ -182,6 +182,49 @@ void testRecordActionableError_logsErrorInfo() {
         attributesMap.get(ObservabilityAttributes.ERROR_METADATA_ATTRIBUTE_PREFIX + "test_key"));
   }
 
+  @Test
+  void testRecordActionableError_logsExceptionDetails() {
+    ApiTracerContext context = ApiTracerContext.empty();
+    LoggingTracer tracer = new LoggingTracer(context);
+
+    Exception error = new RuntimeException("test error message");
+    tracer.recordActionableError(error);
+
+    Map<String, ?> attributesMap = getAttributesMap();
+
+    assertTrue(attributesMap != null && !attributesMap.isEmpty());
+    assertEquals(
+        "java.lang.RuntimeException",
+        attributesMap.get(ObservabilityAttributes.EXCEPTION_TYPE_ATTRIBUTE));
+    assertEquals("test error message", attributesMap.get("exception.message"));
+  }
+
+  @Test
+  void testRecordActionableError_logsHttpStatus() {
+    ApiTracerContext context =
+        ApiTracerContext.empty().toBuilder().setTransport(ApiTracerContext.Transport.HTTP).build();
+    LoggingTracer tracer = new LoggingTracer(context);
+
+    Exception error =
+        ApiExceptionFactory.createException(
+            "test error message",
+            new RuntimeException("cause"),
+            FakeStatusCode.of(StatusCode.Code.INVALID_ARGUMENT),
+            false);
+
+    tracer.recordActionableError(error);
+
+    Map<String, ?> attributesMap = getAttributesMap();
+
+    assertTrue(attributesMap != null && !attributesMap.isEmpty());
+    assertEquals(
+        "INVALID_ARGUMENT",
+        attributesMap.get(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE));
+    assertEquals(
+        400L,
+        attributesMap.get(ObservabilityAttributes.HTTP_RESPONSE_STATUS_ATTRIBUTE));
+  }
+
   private Map<String, ?> getAttributesMap() {
     if (!testLogger.getMDCMap().isEmpty()) {
       return testLogger.getMDCMap();