Skip to content

Commit 029dba5

Browse files
committed
chore(gax-grpc): add comments and remove magic numbers for resize delta
1 parent cbed3e6 commit 029dba5

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

sdk-platform-java/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/ChannelPool.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ class ChannelPool extends ManagedChannel {
8484
private final AtomicInteger indexTicker = new AtomicInteger();
8585
private final String authority;
8686

87+
// Tracks the number of consecutive resize cycles where a resize actually occurred (either expand or shrink).
88+
// Used to detect repeated resizing activity and log a warning.
8789
private int consecutiveResizes = 0;
8890

8991
static ChannelPool create(

sdk-platform-java/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/ChannelPoolSettings.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public static ChannelPoolSettings staticallySized(int size) {
141141
.setMaxRpcsPerChannel(Integer.MAX_VALUE)
142142
.setMinChannelCount(size)
143143
.setMaxChannelCount(size)
144-
.setMaxResizeDelta(Math.min(2, size))
144+
.setMaxResizeDelta(Math.min(MAX_RESIZE_DELTA, size))
145145
.build();
146146
}
147147

@@ -153,7 +153,7 @@ public static Builder builder() {
153153
.setMinRpcsPerChannel(0)
154154
.setMaxRpcsPerChannel(Integer.MAX_VALUE)
155155
.setPreemptiveRefreshEnabled(false)
156-
.setMaxResizeDelta(2);
156+
.setMaxResizeDelta(MAX_RESIZE_DELTA);
157157
}
158158

159159
@AutoValue.Builder

0 commit comments

Comments
 (0)