Skip to content

Commit 09e2d4f

Browse files
committed
Manual fixes for java-spanner-jdbc
1 parent 92940b4 commit 09e2d4f

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

.github/workflows/java-spanner-jdbc-ci.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,3 +137,5 @@ jobs:
137137
- run: .kokoro/build.sh
138138
env:
139139
JOB_TYPE: lint
140+
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
141+
BASE_SHA: ${{ github.event.pull_request.base.sha }}

java-spanner-jdbc/pom.xml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,13 +207,13 @@
207207
<dependency>
208208
<groupId>com.google.cloud</groupId>
209209
<artifactId>google-cloud-trace</artifactId>
210-
<version>2.86.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-trace:current} -->
210+
<version>2.89.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-trace:current} -->
211211
<scope>test</scope>
212212
</dependency>
213213
<dependency>
214214
<groupId>com.google.api.grpc</groupId>
215215
<artifactId>proto-google-cloud-trace-v1</artifactId>
216-
<version>2.86.0-SNAPSHOT</version><!-- {x-version-update:proto-google-cloud-trace-v1:current} -->
216+
<version>2.89.0-SNAPSHOT</version><!-- {x-version-update:proto-google-cloud-trace-v1:current} -->
217217
<scope>test</scope>
218218
</dependency>
219219

@@ -345,10 +345,12 @@
345345
</goals>
346346
<configuration>
347347
<mainClass>com.google.cloud.spanner.jdbc.ConnectionPropertiesFileGenerator</mainClass>
348+
<arguments>
349+
<argument>${project.basedir}/documentation/connection_properties.md</argument>
350+
</arguments>
348351
<classpathScope>test</classpathScope>
349352
<skip>false</skip>
350-
</configuration>
351-
</execution>
353+
</configuration> </execution>
352354
</executions>
353355
</plugin>
354356
</plugins>

java-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/ConnectionPropertiesFileGenerator.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
public class ConnectionPropertiesFileGenerator {
2929

3030
public static void main(String[] args) throws IOException {
31+
String filename =
32+
args.length > 0 ? args[0] : "documentation/connection_properties.md";
3133
StringBuilder builder =
3234
new StringBuilder("# Supported Connection Properties\n\n")
3335
.append(
@@ -57,8 +59,7 @@ public static void main(String[] args) throws IOException {
5759
.append(connectionProperty.getContext())
5860
.append(" |\n");
5961
}
60-
try (BufferedWriter writer =
61-
new BufferedWriter(new FileWriter("documentation/connection_properties.md"))) {
62+
try (BufferedWriter writer = new BufferedWriter(new FileWriter(filename))) {
6263
writer.write(builder.toString());
6364
}
6465
}

0 commit comments

Comments
 (0)