fix: restore default overload

Author: diegomarquezp

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/GoldenSignalsMetricsTracer.java

@@ -29,9 +29,11 @@
  */
 package com.google.api.gax.tracing;
 
+import static com.google.api.gax.tracing.ObservabilityAttributes.HTTP_RESPONSE_STATUS_ATTRIBUTE;
 import static com.google.api.gax.tracing.ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE;
 
 import com.google.api.gax.rpc.StatusCode;
+import com.google.api.gax.tracing.ApiTracerContext.Transport;
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Stopwatch;
 import com.google.common.base.Ticker;
@@ -91,8 +93,13 @@ public void operationCancelled() {
 
   @Override
   public void operationFailed(Throwable error) {
-    attributes.put(
-        RPC_RESPONSE_STATUS_ATTRIBUTE, ObservabilityUtils.extractStatus(error, transport));
+    if (transport == Transport.HTTP) {
+      attributes.put(
+          HTTP_RESPONSE_STATUS_ATTRIBUTE, ObservabilityUtils.extractStatus(error, transport));
+    } else {
+      attributes.put(
+          RPC_RESPONSE_STATUS_ATTRIBUTE, ObservabilityUtils.extractStatus(error, transport));
+    }
     metricsRecorder.recordOperationLatency(
         clientRequestTimer.elapsed(TimeUnit.NANOSECONDS) / 1_000_000_000.0, attributes);
   }

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/LoggingTracer.java

@@ -34,7 +34,6 @@
 import com.google.api.core.InternalApi;
 import com.google.api.gax.logging.LoggerProvider;
 import com.google.api.gax.logging.LoggingUtils;
-import com.google.api.gax.tracing.ApiTracerContext.Transport;
 import com.google.common.annotations.VisibleForTesting;
 import com.google.rpc.ErrorInfo;
 import java.util.HashMap;
@@ -81,7 +80,7 @@ void recordActionableError(Throwable error) {
 
     logContext.put(
         ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE,
-        ObservabilityUtils.extractStatus(error, Transport.GRPC));
+        ObservabilityUtils.extractStatus(error));
 
     ErrorInfo errorInfo = ObservabilityUtils.extractErrorInfo(error);
     if (errorInfo != null) {

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/MetricsTracer.java

@@ -120,9 +120,7 @@ public void operationFailed(Throwable error) {
     if (operationFinished.getAndSet(true)) {
       throw new IllegalStateException(OPERATION_FINISHED_STATUS_MESSAGE);
     }
-    attributes.put(
-        STATUS_ATTRIBUTE,
-        (String) ObservabilityUtils.extractStatus(error, ApiTracerContext.Transport.GRPC));
+    attributes.put(STATUS_ATTRIBUTE, (String) ObservabilityUtils.extractStatus(error));
     metricsRecorder.recordOperationLatency(
         operationTimer.elapsed(TimeUnit.MILLISECONDS), attributes);
     metricsRecorder.recordOperationCount(1, attributes);
@@ -174,9 +172,7 @@ public void attemptCancelled() {
    */
   @Override
   public void attemptFailedDuration(Throwable error, java.time.Duration delay) {
-    attributes.put(
-        STATUS_ATTRIBUTE,
-        (String) ObservabilityUtils.extractStatus(error, ApiTracerContext.Transport.GRPC));
+    attributes.put(STATUS_ATTRIBUTE, (String) ObservabilityUtils.extractStatus(error));
     metricsRecorder.recordAttemptLatency(attemptTimer.elapsed(TimeUnit.MILLISECONDS), attributes);
     metricsRecorder.recordAttemptCount(1, attributes);
   }
@@ -200,9 +196,7 @@ public void attemptFailed(Throwable error, org.threeten.bp.Duration delay) {
    */
   @Override
   public void attemptFailedRetriesExhausted(Throwable error) {
-    attributes.put(
-        STATUS_ATTRIBUTE,
-        (String) ObservabilityUtils.extractStatus(error, ApiTracerContext.Transport.GRPC));
+    attributes.put(STATUS_ATTRIBUTE, (String) ObservabilityUtils.extractStatus(error));
     metricsRecorder.recordAttemptLatency(attemptTimer.elapsed(TimeUnit.MILLISECONDS), attributes);
     metricsRecorder.recordAttemptCount(1, attributes);
   }
@@ -216,9 +210,7 @@ public void attemptFailedRetriesExhausted(Throwable error) {
    */
   @Override
   public void attemptPermanentFailure(Throwable error) {
-    attributes.put(
-        STATUS_ATTRIBUTE,
-        (String) ObservabilityUtils.extractStatus(error, ApiTracerContext.Transport.GRPC));
+    attributes.put(STATUS_ATTRIBUTE, (String) ObservabilityUtils.extractStatus(error));
     metricsRecorder.recordAttemptLatency(attemptTimer.elapsed(TimeUnit.MILLISECONDS), attributes);
     metricsRecorder.recordAttemptCount(1, attributes);
   }

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/ObservabilityUtils.java

@@ -43,6 +43,11 @@
 
 final class ObservabilityUtils {
 
+  /** Function to extract the status of the error as a string (defaults to gRPC canonical codes). */
+  static String extractStatus(@Nullable Throwable error) {
+    return (String) extractStatus(error, ApiTracerContext.Transport.GRPC);
+  }
+
   static Object extractStatus(@Nullable Throwable error, ApiTracerContext.Transport transport) {
     if (transport == ApiTracerContext.Transport.HTTP) {
       return extractHttpStatus(error);