Skip to content

Commit 12daf8c

Browse files
committed
chore: update gemini suggestions
1 parent 3cda27f commit 12daf8c

File tree

5 files changed

+14
-11
lines changed

5 files changed

+14
-11
lines changed

java-bigquery/google-cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITBase.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,8 @@ protected int resultSetRowCount(ResultSet resultSet) throws SQLException {
170170
public static List<String> getInfoBySQL(Connection connection, String sqlCmd)
171171
throws SQLException {
172172
List<String> result = new ArrayList<>();
173-
try {
174-
Statement st = connection.createStatement();
175-
ResultSet rs = st.executeQuery(sqlCmd);
173+
try (Statement st = connection.createStatement();
174+
ResultSet rs = st.executeQuery(sqlCmd)) {
176175
while (rs.next()) {
177176
result.add(rs.getString(1));
178177
}

java-bigquery/google-cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITConnectionPoolingTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,5 +352,8 @@ private void assertConnectionPoolingResults(String connectionURL, Long connectio
352352
assertEquals(1, listener.getConnectionPoolCurrentCapacity());
353353
assertEquals(connectionPoolSize, listener.getConnectionPoolSize());
354354
pooledConnection.close();
355+
jsonResultSet.close();
356+
statement.close();
357+
connection.close();
355358
}
356359
}

java-bigquery/google-cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITConnectionTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@
4242

4343
public class ITConnectionTest {
4444

45-
private static final String DATASET = "EXT_JDBC_CONNECTION_TEST_DATASET";
45+
private static final String DATASET = "JDBC_CONNECTION_TEST_DATASET";
4646
private static final String DEFAULT_CATALOG = ServiceOptions.getDefaultProjectId();
4747
static Random random = new Random();
4848
static int randomNumber = random.nextInt(999);
49-
private static final String TABLE_NAME = "EXT_JDBC_CONNECTION_TEST_TABLE" + randomNumber;
49+
private static final String TABLE_NAME = "JDBC_CONNECTION_TEST_TABLE" + randomNumber;
5050

5151
private static String connectionUrl =
5252
"jdbc:bigquery://https://www.googleapis.com/bigquery/v2:443;ProjectId=%s;OAuthType=3;Timeout=3600;";

java-bigquery/google-cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITDriverTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ public void testGetDriverMethod() throws SQLException, InterruptedException {
6565
+ OAUTH_TYPE
6666
+ ";LOCATION=US;";
6767

68-
String dataset = "EXT_JDBC_DRIVER_TEST_DATASET" + random.nextInt(999);
69-
String tableName = "EXT_JDBC_DRIVER_TEST_TABLE" + randomNumber;
68+
String dataset = "JDBC_DRIVER_TEST_DATASET" + random.nextInt(999);
69+
String tableName = "JDBC_DRIVER_TEST_TABLE" + randomNumber;
7070

7171
Driver driver = DriverManager.getDriver(CONNECTION_URL);
7272

@@ -92,8 +92,8 @@ public void testGetDriverMethod() throws SQLException, InterruptedException {
9292
@Test
9393
public void testDriverLocation() throws SQLException, InterruptedException {
9494

95-
String datasetUS = "EXT_JDBC_DRIVER_US_TEST_DATASET" + random.nextInt(999);
96-
String tableNameUS = "EXT_JDBC_DRIVER_US_TEST_TABLE" + randomNumber;
95+
String datasetUS = "JDBC_DRIVER_US_TEST_DATASET" + random.nextInt(999);
96+
String tableNameUS = "JDBC_DRIVER_US_TEST_TABLE" + randomNumber;
9797
String OAUTH_TYPE = "3";
9898
String CONNECTION_URL =
9999
"jdbc:bigquery://https://bigquery.googleapis.com/bigquery/v2/:443;ProjectId=%s;OAuthType=%s;LOCATION=%s;";
@@ -116,5 +116,6 @@ public void testDriverLocation() throws SQLException, InterruptedException {
116116
Dataset retrievedDataset = bigQuery.getDataset(DatasetId.of(DEFAULT_CATALOG, datasetUS));
117117
assertEquals("us-east5", retrievedDataset.getLocation());
118118
ITBase.cleanUp(datasetUS);
119+
connectionUS.close();
119120
}
120121
}

java-bigquery/google-cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITResultSetMetadataTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ public class ITResultSetMetadataTest {
3535
private static final String DEFAULT_CATALOG = ServiceOptions.getDefaultProjectId();
3636
static Random random = new Random();
3737
static int randomNumber = random.nextInt(999);
38-
private static final String TABLE_NAME = "EXT_JDBC_RSMETADATA_TEST_TABLE" + randomNumber;
39-
private static final String DATASET = "EXT_JDBC_RSMETADATA_TEST_DATASET";
38+
private static final String TABLE_NAME = "JDBC_RSMETADATA_TEST_TABLE" + randomNumber;
39+
private static final String DATASET = "JDBC_RSMETADATA_TEST_DATASET";
4040
private static ResultSetMetaData metaData;
4141

4242
@BeforeClass

0 commit comments

Comments
 (0)