fix(jdbc): clone Calendar parameter in date/time setters to prevent mutation

Author: Neenu1995

java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryPreparedStatement.java

@@ -543,16 +543,17 @@ public void setDate(int parameterIndex, Date x, Calendar cal) throws SQLExceptio
       setDate(parameterIndex, x);
       return;
     }
+    Calendar targetCal = (Calendar) cal.clone();
     Calendar defaultCal = Calendar.getInstance();
     defaultCal.setTime(x);
-    cal.set(Calendar.YEAR, defaultCal.get(Calendar.YEAR));
-    cal.set(Calendar.MONTH, defaultCal.get(Calendar.MONTH));
-    cal.set(Calendar.DAY_OF_MONTH, defaultCal.get(Calendar.DAY_OF_MONTH));
-    cal.set(Calendar.HOUR_OF_DAY, 0);
-    cal.set(Calendar.MINUTE, 0);
-    cal.set(Calendar.SECOND, 0);
-    cal.set(Calendar.MILLISECOND, 0);
-    setDate(parameterIndex, new Date(cal.getTimeInMillis()));
+    targetCal.set(Calendar.YEAR, defaultCal.get(Calendar.YEAR));
+    targetCal.set(Calendar.MONTH, defaultCal.get(Calendar.MONTH));
+    targetCal.set(Calendar.DAY_OF_MONTH, defaultCal.get(Calendar.DAY_OF_MONTH));
+    targetCal.set(Calendar.HOUR_OF_DAY, 0);
+    targetCal.set(Calendar.MINUTE, 0);
+    targetCal.set(Calendar.SECOND, 0);
+    targetCal.set(Calendar.MILLISECOND, 0);
+    setDate(parameterIndex, new Date(targetCal.getTimeInMillis()));
   }
 
   @Override
@@ -566,13 +567,14 @@ public void setTime(int parameterIndex, Time x, Calendar cal) throws SQLExceptio
       setTime(parameterIndex, x);
       return;
     }
+    Calendar targetCal = (Calendar) cal.clone();
     Calendar defaultCal = Calendar.getInstance();
     defaultCal.setTime(x);
-    cal.set(Calendar.HOUR_OF_DAY, defaultCal.get(Calendar.HOUR_OF_DAY));
-    cal.set(Calendar.MINUTE, defaultCal.get(Calendar.MINUTE));
-    cal.set(Calendar.SECOND, defaultCal.get(Calendar.SECOND));
-    cal.set(Calendar.MILLISECOND, defaultCal.get(Calendar.MILLISECOND));
-    setTime(parameterIndex, new Time(cal.getTimeInMillis()));
+    targetCal.set(Calendar.HOUR_OF_DAY, defaultCal.get(Calendar.HOUR_OF_DAY));
+    targetCal.set(Calendar.MINUTE, defaultCal.get(Calendar.MINUTE));
+    targetCal.set(Calendar.SECOND, defaultCal.get(Calendar.SECOND));
+    targetCal.set(Calendar.MILLISECOND, defaultCal.get(Calendar.MILLISECOND));
+    setTime(parameterIndex, new Time(targetCal.getTimeInMillis()));
   }
 
   @Override
@@ -586,16 +588,17 @@ public void setTimestamp(int parameterIndex, Timestamp x, Calendar cal) throws S
       setTimestamp(parameterIndex, x);
       return;
     }
+    Calendar targetCal = (Calendar) cal.clone();
     Calendar defaultCal = Calendar.getInstance();
     defaultCal.setTime(x);
-    cal.set(Calendar.YEAR, defaultCal.get(Calendar.YEAR));
-    cal.set(Calendar.MONTH, defaultCal.get(Calendar.MONTH));
-    cal.set(Calendar.DAY_OF_MONTH, defaultCal.get(Calendar.DAY_OF_MONTH));
-    cal.set(Calendar.HOUR_OF_DAY, defaultCal.get(Calendar.HOUR_OF_DAY));
-    cal.set(Calendar.MINUTE, defaultCal.get(Calendar.MINUTE));
-    cal.set(Calendar.SECOND, defaultCal.get(Calendar.SECOND));
-    cal.set(Calendar.MILLISECOND, defaultCal.get(Calendar.MILLISECOND));
-    Timestamp adjustedTimestamp = new Timestamp(cal.getTimeInMillis());
+    targetCal.set(Calendar.YEAR, defaultCal.get(Calendar.YEAR));
+    targetCal.set(Calendar.MONTH, defaultCal.get(Calendar.MONTH));
+    targetCal.set(Calendar.DAY_OF_MONTH, defaultCal.get(Calendar.DAY_OF_MONTH));
+    targetCal.set(Calendar.HOUR_OF_DAY, defaultCal.get(Calendar.HOUR_OF_DAY));
+    targetCal.set(Calendar.MINUTE, defaultCal.get(Calendar.MINUTE));
+    targetCal.set(Calendar.SECOND, defaultCal.get(Calendar.SECOND));
+    targetCal.set(Calendar.MILLISECOND, defaultCal.get(Calendar.MILLISECOND));
+    Timestamp adjustedTimestamp = new Timestamp(targetCal.getTimeInMillis());
     adjustedTimestamp.setNanos(x.getNanos());
     setTimestamp(parameterIndex, adjustedTimestamp);
   }

java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryPreparedStatementSettersTest.java

@@ -179,28 +179,37 @@ public void testGetParameterMetaData() throws Exception {
   @Test
   public void testSetDateWithCalendar() throws Exception {
     Calendar cal = Calendar.getInstance(TimeZone.getTimeZone("UTC"));
+    cal.setTimeInMillis(1000000L);
+    long originalMillis = cal.getTimeInMillis();
     Date date = new Date(1700000000000L); // 2023-11-14
 
     preparedStatement.setDate(1, date, cal);
     assertEquals(String.class, preparedStatement.parameterHandler.getType(1));
+    assertEquals(originalMillis, cal.getTimeInMillis());
   }
 
   @Test
   public void testSetTimeWithCalendar() throws Exception {
     Calendar cal = Calendar.getInstance(TimeZone.getTimeZone("UTC"));
+    cal.setTimeInMillis(1000000L);
+    long originalMillis = cal.getTimeInMillis();
     Time time = new Time(43200000L); // 12:00:00
 
     preparedStatement.setTime(1, time, cal);
     assertEquals(String.class, preparedStatement.parameterHandler.getType(1));
+    assertEquals(originalMillis, cal.getTimeInMillis());
   }
 
   @Test
   public void testSetTimestampWithCalendar() throws Exception {
     Calendar cal = Calendar.getInstance(TimeZone.getTimeZone("UTC"));
+    cal.setTimeInMillis(1000000L);
+    long originalMillis = cal.getTimeInMillis();
     Timestamp ts = new Timestamp(1700000000000L);
 
     preparedStatement.setTimestamp(1, ts, cal);
     assertEquals(String.class, preparedStatement.parameterHandler.getType(1));
+    assertEquals(originalMillis, cal.getTimeInMillis());
   }
 
   @Test