Skip to content

Commit 1fbacff

Browse files
committed
test(logging): expose and reuse TEST_SINK_PREFIX from RemoteLoggingHelper
Exposes TEST_SINK_PREFIX as public constant in RemoteLoggingHelper and statically imports it directly into ITSinkTest, removing duplicate local constant declarations. BUG=b/482174880 TAG=agy CONV=d4a74f94-579a-4c3f-96c3-f90fcbc6c699
1 parent 20ab0e9 commit 1fbacff

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

java-logging/google-cloud-logging/src/main/java/com/google/cloud/logging/testing/RemoteLoggingHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
public class RemoteLoggingHelper {
3838

3939
private static final Logger log = Logger.getLogger(RemoteLoggingHelper.class.getName());
40-
private static final String TEST_SINK_PREFIX = "test-";
40+
public static final String TEST_SINK_PREFIX = "test-";
4141
private final LoggingOptions options;
4242

4343
private RemoteLoggingHelper(LoggingOptions options) {

java-logging/google-cloud-logging/src/test/java/com/google/cloud/logging/it/ITSinkTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package com.google.cloud.logging.it;
1818

19+
import static com.google.cloud.logging.testing.RemoteLoggingHelper.TEST_SINK_PREFIX;
1920
import static com.google.cloud.logging.testing.RemoteLoggingHelper.formatForTest;
2021
import static org.junit.Assert.assertEquals;
2122
import static org.junit.Assert.assertFalse;
@@ -38,8 +39,6 @@
3839

3940
public class ITSinkTest extends BaseSystemTest {
4041

41-
private static final String TEST_SINK_PREFIX = "test-";
42-
4342
@BeforeClass
4443
public static void setUp() {
4544
// Cleanup all stucked sinks if any

0 commit comments

Comments
 (0)