Skip to content

Commit 266cf90

Browse files
committed
chore: remove language from bigquery telemetry tracing
1 parent 9276fbf commit 266cf90

File tree

4 files changed

+0
-13
lines changed

4 files changed

+0
-13
lines changed

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/telemetry/BigQueryTelemetryTracer.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ private BigQueryTelemetryTracer() {}
3434
public static final String BQ_GCP_CLIENT_SERVICE = "bigquery";
3535
public static final String BQ_GCP_CLIENT_REPO = "googleapis/google-cloud-java";
3636
public static final String BQ_GCP_CLIENT_ARTIFACT = "google-cloud-bigquery";
37-
public static final String BQ_GCP_CLIENT_LANGUAGE = "java";
3837

3938
// TODO: migrate to use gax attributes keys
4039
// https://github.com/googleapis/google-cloud-java/issues/12099
@@ -47,8 +46,6 @@ private BigQueryTelemetryTracer() {}
4746
AttributeKey.stringKey("gcp.client.repo");
4847
public static final AttributeKey<String> GCP_CLIENT_ARTIFACT =
4948
AttributeKey.stringKey("gcp.client.artifact");
50-
public static final AttributeKey<String> GCP_CLIENT_LANGUAGE =
51-
AttributeKey.stringKey("gcp.client.language");
5249
public static final AttributeKey<String> GCP_RESOURCE_DESTINATION_ID =
5350
AttributeKey.stringKey("gcp.resource.destination.id");
5451
public static final AttributeKey<String> RPC_SYSTEM_NAME =
@@ -68,7 +65,6 @@ public static void addCommonAttributeToSpan(Span span) {
6865
span.setAttribute(GCP_CLIENT_SERVICE, BQ_GCP_CLIENT_SERVICE)
6966
.setAttribute(GCP_CLIENT_REPO, BQ_GCP_CLIENT_REPO)
7067
.setAttribute(GCP_CLIENT_ARTIFACT, BQ_GCP_CLIENT_ARTIFACT)
71-
.setAttribute(GCP_CLIENT_LANGUAGE, BQ_GCP_CLIENT_LANGUAGE)
7268
.setAttribute(GCP_CLIENT_VERSION, Version.VERSION);
7369
}
7470

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITOpenTelemetryTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -305,9 +305,6 @@ private void checkGeneralAttributes(Map<AttributeKey<?>, Object> attrs) {
305305
assertEquals(
306306
BigQueryTelemetryTracer.BQ_GCP_CLIENT_REPO,
307307
attrs.get(BigQueryTelemetryTracer.GCP_CLIENT_REPO));
308-
assertEquals(
309-
BigQueryTelemetryTracer.BQ_GCP_CLIENT_LANGUAGE,
310-
attrs.get(BigQueryTelemetryTracer.GCP_CLIENT_LANGUAGE));
311308
assertEquals(
312309
BigQueryTelemetryTracer.BQ_GCP_CLIENT_ARTIFACT,
313310
attrs.get(BigQueryTelemetryTracer.GCP_CLIENT_ARTIFACT));

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/telemetry/BigQueryTelemetryTracerTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,9 +181,6 @@ public void testAddCommonAttributeToSpan() {
181181
assertEquals(
182182
BigQueryTelemetryTracer.BQ_GCP_CLIENT_ARTIFACT,
183183
spanData.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_ARTIFACT));
184-
assertEquals(
185-
BigQueryTelemetryTracer.BQ_GCP_CLIENT_LANGUAGE,
186-
spanData.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_LANGUAGE));
187184
assertEquals(
188185
Version.VERSION, spanData.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_VERSION));
189186
}

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/telemetry/HttpTracingRequestInitializerTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -447,9 +447,6 @@ private void closeAndVerifySpanData(
447447
assertEquals(
448448
BigQueryTelemetryTracer.BQ_GCP_CLIENT_ARTIFACT,
449449
span.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_ARTIFACT));
450-
assertEquals(
451-
BigQueryTelemetryTracer.BQ_GCP_CLIENT_LANGUAGE,
452-
span.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_LANGUAGE));
453450
assertEquals(
454451
HttpTracingRequestInitializer.HTTP_RPC_SYSTEM_NAME,
455452
span.getAttributes().get(BigQueryTelemetryTracer.RPC_SYSTEM_NAME));

0 commit comments

Comments
 (0)