Skip to content

Commit 291add8

Browse files
authored
chore: add comment markers to pom.xml files (#13443)
Add comment markers in pom.xml for generated proto and grpc artifacts. These markers are added in parent, BOM and client pom.xml files for each library. Removing some markers to showcase, because hermetic build code gen is used in showcase golden tests. Will work on it separately googleapis/librarian#6393. For googleapis/librarian#6134
1 parent 70f9781 commit 291add8

717 files changed

Lines changed: 2644 additions & 266 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

java-accessapproval/google-cloud-accessapproval-bom/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
<dependencyManagement>
2222
<dependencies>
23+
<!-- {x-generated-dependencies-start} -->
2324
<dependency>
2425
<groupId>com.google.cloud</groupId>
2526
<artifactId>google-cloud-accessapproval</artifactId>
@@ -35,6 +36,7 @@
3536
<artifactId>proto-google-cloud-accessapproval-v1</artifactId>
3637
<version>2.94.0</version><!-- {x-version-update:proto-google-cloud-accessapproval-v1:current} -->
3738
</dependency>
39+
<!-- {x-generated-dependencies-end} -->
3840
</dependencies>
3941
</dependencyManagement>
4042
</project>

java-accessapproval/google-cloud-accessapproval/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,12 @@
4040
<groupId>com.google.api.grpc</groupId>
4141
<artifactId>proto-google-common-protos</artifactId>
4242
</dependency>
43+
<!-- {x-generated-proto-dependencies-start} -->
4344
<dependency>
4445
<groupId>com.google.api.grpc</groupId>
4546
<artifactId>proto-google-cloud-accessapproval-v1</artifactId>
4647
</dependency>
48+
<!-- {x-generated-proto-dependencies-end} -->
4749
<dependency>
4850
<groupId>com.google.guava</groupId>
4951
<artifactId>guava</artifactId>
@@ -71,11 +73,13 @@
7173
<artifactId>junit</artifactId>
7274
<scope>test</scope>
7375
</dependency>
76+
<!-- {x-generated-grpc-dependencies-start} -->
7477
<dependency>
7578
<groupId>com.google.api.grpc</groupId>
7679
<artifactId>grpc-google-cloud-accessapproval-v1</artifactId>
7780
<scope>test</scope>
7881
</dependency>
82+
<!-- {x-generated-grpc-dependencies-end} -->
7983
<!-- Need testing utility classes for generated gRPC clients tests -->
8084
<dependency>
8185
<groupId>com.google.api</groupId>

java-accessapproval/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
<dependencyManagement>
2828
<dependencies>
29+
<!-- {x-generated-dependencies-start} -->
2930
<dependency>
3031
<groupId>com.google.api.grpc</groupId>
3132
<artifactId>proto-google-cloud-accessapproval-v1</artifactId>
@@ -41,15 +42,18 @@
4142
<artifactId>google-cloud-accessapproval</artifactId>
4243
<version>2.94.0</version><!-- {x-version-update:google-cloud-accessapproval:current} -->
4344
</dependency>
45+
<!-- {x-generated-dependencies-end} -->
4446

4547
<!-- Test dependencies -->
4648
</dependencies>
4749
</dependencyManagement>
4850

4951
<modules>
52+
<!-- {x-generated-modules-start} -->
5053
<module>google-cloud-accessapproval</module>
5154
<module>grpc-google-cloud-accessapproval-v1</module>
5255
<module>proto-google-cloud-accessapproval-v1</module>
56+
<!-- {x-generated-modules-end} -->
5357
<module>google-cloud-accessapproval-bom</module>
5458
</modules>
5559

java-accesscontextmanager/google-identity-accesscontextmanager-bom/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
<dependencyManagement>
2626
<dependencies>
27+
<!-- {x-generated-dependencies-start} -->
2728
<dependency>
2829
<groupId>com.google.cloud</groupId>
2930
<artifactId>google-identity-accesscontextmanager</artifactId>
@@ -44,6 +45,7 @@
4445
<artifactId>proto-google-identity-accesscontextmanager-type</artifactId>
4546
<version>1.94.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-type:current} -->
4647
</dependency>
48+
<!-- {x-generated-dependencies-end} -->
4749
</dependencies>
4850
</dependencyManagement>
4951
</project>

java-accesscontextmanager/google-identity-accesscontextmanager/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,12 @@
4141
<artifactId>proto-google-common-protos</artifactId>
4242
</dependency>
4343

44+
<!-- {x-generated-proto-dependencies-start} -->
4445
<dependency>
4546
<groupId>com.google.api.grpc</groupId>
4647
<artifactId>proto-google-identity-accesscontextmanager-v1</artifactId>
4748
</dependency>
49+
<!-- {x-generated-proto-dependencies-end} -->
4850
<dependency>
4951
<groupId>com.google.guava</groupId>
5052
<artifactId>guava</artifactId>
@@ -73,11 +75,13 @@
7375
<scope>test</scope>
7476
</dependency>
7577

78+
<!-- {x-generated-grpc-dependencies-start} -->
7679
<dependency>
7780
<groupId>com.google.api.grpc</groupId>
7881
<artifactId>grpc-google-identity-accesscontextmanager-v1</artifactId>
7982
<scope>test</scope>
8083
</dependency>
84+
<!-- {x-generated-grpc-dependencies-end} -->
8185
<!-- Need testing utility classes for generated gRPC clients tests -->
8286
<dependency>
8387
<groupId>com.google.api</groupId>

java-accesscontextmanager/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
<dependencyManagement>
2828
<dependencies>
2929

30+
<!-- {x-generated-dependencies-start} -->
3031
<dependency>
3132
<groupId>com.google.api.grpc</groupId>
3233
<artifactId>proto-google-identity-accesscontextmanager-type</artifactId>
@@ -47,14 +48,17 @@
4748
<artifactId>google-identity-accesscontextmanager</artifactId>
4849
<version>1.94.0</version><!-- {x-version-update:google-identity-accesscontextmanager:current} -->
4950
</dependency>
51+
<!-- {x-generated-dependencies-end} -->
5052
</dependencies>
5153
</dependencyManagement>
5254

5355
<modules>
56+
<!-- {x-generated-modules-start} -->
5457
<module>google-identity-accesscontextmanager</module>
5558
<module>grpc-google-identity-accesscontextmanager-v1</module>
5659
<module>proto-google-identity-accesscontextmanager-v1</module>
5760
<module>proto-google-identity-accesscontextmanager-type</module>
61+
<!-- {x-generated-modules-end} -->
5862
<module>google-identity-accesscontextmanager-bom</module>
5963
</modules>
6064

java-admanager/ad-manager-bom/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
<dependencyManagement>
2525
<dependencies>
26+
<!-- {x-generated-dependencies-start} -->
2627
<dependency>
2728
<groupId>com.google.api-ads</groupId>
2829
<artifactId>ad-manager</artifactId>
@@ -33,6 +34,7 @@
3334
<artifactId>proto-ad-manager-v1</artifactId>
3435
<version>0.52.0</version><!-- {x-version-update:proto-ad-manager-v1:current} -->
3536
</dependency>
37+
<!-- {x-generated-dependencies-end} -->
3638
</dependencies>
3739
</dependencyManagement>
3840
</project>

java-admanager/ad-manager/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,12 @@
4141
<artifactId>proto-google-common-protos</artifactId>
4242
</dependency>
4343

44+
<!-- {x-generated-proto-dependencies-start} -->
4445
<dependency>
4546
<groupId>com.google.api-ads.api.grpc</groupId>
4647
<artifactId>proto-ad-manager-v1</artifactId>
4748
</dependency>
49+
<!-- {x-generated-proto-dependencies-end} -->
4850
<dependency>
4951
<groupId>com.google.guava</groupId>
5052
<artifactId>guava</artifactId>

java-admanager/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
<dependencyManagement>
2828
<dependencies>
29+
<!-- {x-generated-dependencies-start} -->
2930
<dependency>
3031
<groupId>com.google.api-ads</groupId>
3132
<artifactId>ad-manager</artifactId>
@@ -36,13 +37,16 @@
3637
<artifactId>proto-ad-manager-v1</artifactId>
3738
<version>0.52.0</version><!-- {x-version-update:proto-ad-manager-v1:current} -->
3839
</dependency>
40+
<!-- {x-generated-dependencies-end} -->
3941

4042
</dependencies>
4143
</dependencyManagement>
4244

4345
<modules>
46+
<!-- {x-generated-modules-start} -->
4447
<module>ad-manager</module>
4548
<module>proto-ad-manager-v1</module>
49+
<!-- {x-generated-modules-end} -->
4650
<module>ad-manager-bom</module>
4751
</modules>
4852

java-advisorynotifications/google-cloud-advisorynotifications-bom/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
<dependencyManagement>
2626
<dependencies>
27+
<!-- {x-generated-dependencies-start} -->
2728
<dependency>
2829
<groupId>com.google.cloud</groupId>
2930
<artifactId>google-cloud-advisorynotifications</artifactId>
@@ -39,6 +40,7 @@
3940
<artifactId>proto-google-cloud-advisorynotifications-v1</artifactId>
4041
<version>0.82.0</version><!-- {x-version-update:proto-google-cloud-advisorynotifications-v1:current} -->
4142
</dependency>
43+
<!-- {x-generated-dependencies-end} -->
4244
</dependencies>
4345
</dependencyManagement>
4446
</project>

0 commit comments

Comments
 (0)