Skip to content

Commit 2e03d84

Browse files
authored
ci: fix unmanaged dependency check (#12925)
Fixes #12704 The current checks are not installing all the required modules from the repository -- this fixes the installation of the scripts especially when the versions referenced are all -SNAPSHOT versions. Tested against the release-please version bumps in #12924
1 parent 3deec8a commit 2e03d84

2 files changed

Lines changed: 5 additions & 8 deletions

File tree

.github/workflows/sdk-platform-java-downstream_unmanaged_dependency_check.yaml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,19 +55,17 @@ jobs:
5555
cache: maven
5656
- name: Install the modules of sdk-platform-java
5757
shell: bash
58-
working-directory: google-cloud-java/sdk-platform-java
59-
run: |
60-
set -euo pipefail
61-
# gapic-generator-java is irrelevant
62-
mvn -q -B -ntp install \
63-
-Dcheckstyle.skip -Dfmt.skip -DskipTests -T 1C
58+
run: .kokoro/build.sh
59+
env:
60+
BUILD_SUBDIR: sdk-platform-java
61+
JOB_TYPE: install
62+
working-directory: google-cloud-java
6463
- name: Build unmanaged dependency check
6564
shell: bash
6665
working-directory: google-cloud-java/sdk-platform-java/java-shared-dependencies/unmanaged-dependency-check
6766
run: |
6867
set -euo pipefail
6968
pwd
70-
pwd
7169
echo "Install Unmanaged Dependency Check in $(pwd)"
7270
mvn clean install -V --batch-mode --no-transfer-progress -DskipTests
7371
- name: Install the modules of the downstream repository

.github/workflows/unmanaged_dependency_check.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ jobs:
1414
shell: bash
1515
run: .kokoro/build.sh
1616
env:
17-
BUILD_SUBDIR: sdk-platform-java
1817
JOB_TYPE: install
1918
- name: Unmanaged dependency check
2019
uses: ./sdk-platform-java/java-shared-dependencies/unmanaged-dependency-check

0 commit comments

Comments
 (0)