Skip to content

Commit 2e69446

Browse files
committed
updated to use stringbuilder
1 parent 03f9e98 commit 2e69446

1 file changed

Lines changed: 66 additions & 30 deletions

File tree

  • java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java

Lines changed: 66 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,13 @@ public Dataset getDatasetSkipExceptionTranslation(
179179
.getRequestHeaders()
180180
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
181181

182-
String destinationId = RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId;
182+
String destinationId =
183+
new StringBuilder()
184+
.append(RESOURCE_PROJECT_PREFIX)
185+
.append(projectId)
186+
.append("/datasets/")
187+
.append(datasetId)
188+
.toString();
183189

184190
return executeWithSpan(
185191
createRpcTracingSpan(
@@ -277,10 +283,12 @@ public Dataset createSkipExceptionTranslation(Dataset dataset, Map<Option, ?> op
277283
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
278284

279285
String destinationId =
280-
RESOURCE_PROJECT_PREFIX
281-
+ dataset.getDatasetReference().getProjectId()
282-
+ "/datasets/"
283-
+ dataset.getDatasetReference().getDatasetId();
286+
new StringBuilder()
287+
.append(RESOURCE_PROJECT_PREFIX)
288+
.append(dataset.getDatasetReference().getProjectId())
289+
.append("/datasets/")
290+
.append(dataset.getDatasetReference().getDatasetId())
291+
.toString();
284292

285293
return executeWithSpan(
286294
createRpcTracingSpan(
@@ -326,12 +334,14 @@ public Table createSkipExceptionTranslation(Table table, Map<Option, ?> options)
326334
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
327335

328336
String destinationId =
329-
RESOURCE_PROJECT_PREFIX
330-
+ reference.getProjectId()
331-
+ "/datasets/"
332-
+ reference.getDatasetId()
333-
+ "/tables/"
334-
+ reference.getTableId();
337+
new StringBuilder()
338+
.append(RESOURCE_PROJECT_PREFIX)
339+
.append(reference.getProjectId())
340+
.append("/datasets/")
341+
.append(reference.getDatasetId())
342+
.append("/tables/")
343+
.append(reference.getTableId())
344+
.toString();
335345

336346
return executeWithSpan(
337347
createRpcTracingSpan(
@@ -375,12 +385,14 @@ public Routine createSkipExceptionTranslation(Routine routine, Map<Option, ?> op
375385
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
376386

377387
String destinationId =
378-
RESOURCE_PROJECT_PREFIX
379-
+ reference.getProjectId()
380-
+ "/datasets/"
381-
+ reference.getDatasetId()
382-
+ "/routines/"
383-
+ reference.getRoutineId();
388+
new StringBuilder()
389+
.append(RESOURCE_PROJECT_PREFIX)
390+
.append(reference.getProjectId())
391+
.append("/datasets/")
392+
.append(reference.getDatasetId())
393+
.append("/routines/")
394+
.append(reference.getRoutineId())
395+
.toString();
384396

385397
return executeWithSpan(
386398
createRpcTracingSpan(
@@ -517,7 +529,13 @@ public boolean deleteDatasetSkipExceptionTranslation(
517529
.getRequestHeaders()
518530
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
519531

520-
String destinationId = RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId;
532+
String destinationId =
533+
new StringBuilder()
534+
.append(RESOURCE_PROJECT_PREFIX)
535+
.append(projectId)
536+
.append("/datasets/")
537+
.append(datasetId)
538+
.toString();
521539

522540
return executeWithSpan(
523541
createRpcTracingSpan(
@@ -563,10 +581,12 @@ public Dataset patchSkipExceptionTranslation(Dataset dataset, Map<Option, ?> opt
563581
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
564582

565583
String destinationId =
566-
RESOURCE_PROJECT_PREFIX
567-
+ reference.getProjectId()
568-
+ "/datasets/"
569-
+ reference.getDatasetId();
584+
new StringBuilder()
585+
.append(RESOURCE_PROJECT_PREFIX)
586+
.append(reference.getProjectId())
587+
.append("/datasets/")
588+
.append(reference.getDatasetId())
589+
.toString();
570590

571591
return executeWithSpan(
572592
createRpcTracingSpan(
@@ -614,12 +634,14 @@ public Table patchSkipExceptionTranslation(Table table, Map<Option, ?> options)
614634
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
615635

616636
String destinationId =
617-
RESOURCE_PROJECT_PREFIX
618-
+ reference.getProjectId()
619-
+ "/datasets/"
620-
+ reference.getDatasetId()
621-
+ "/tables/"
622-
+ reference.getTableId();
637+
new StringBuilder()
638+
.append(RESOURCE_PROJECT_PREFIX)
639+
.append(reference.getProjectId())
640+
.append("/datasets/")
641+
.append(reference.getDatasetId())
642+
.append("/tables/")
643+
.append(reference.getTableId())
644+
.toString();
623645

624646
return executeWithSpan(
625647
createRpcTracingSpan(
@@ -669,7 +691,14 @@ public Table getTableSkipExceptionTranslation(
669691
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
670692

671693
String destinationId =
672-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/tables/" + tableId;
694+
new StringBuilder()
695+
.append(RESOURCE_PROJECT_PREFIX)
696+
.append(projectId)
697+
.append("/datasets/")
698+
.append(datasetId)
699+
.append("/tables/")
700+
.append(tableId)
701+
.toString();
673702

674703
return executeWithSpan(
675704
createRpcTracingSpan(
@@ -788,7 +817,14 @@ public boolean deleteTableSkipExceptionTranslation(
788817
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
789818

790819
String destinationId =
791-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/tables/" + tableId;
820+
new StringBuilder()
821+
.append(RESOURCE_PROJECT_PREFIX)
822+
.append(projectId)
823+
.append("/datasets/")
824+
.append(datasetId)
825+
.append("/tables/")
826+
.append(tableId)
827+
.toString();
792828

793829
return executeWithSpan(
794830
createRpcTracingSpan(

0 commit comments

Comments
 (0)