Skip to content

Commit 31a921a

Browse files
committed
address review feedback: replace int[] with AtomicInteger
1 parent 56336b2 commit 31a921a

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

google-auth-library-java/oauth2_http/javatests/com/google/auth/oauth2/ComputeEngineCredentialsTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
import java.util.List;
6868
import java.util.Map;
6969
import java.util.Queue;
70+
import java.util.concurrent.atomic.AtomicInteger;
7071
import java.util.stream.Collectors;
7172
import java.util.stream.IntStream;
7273
import java.util.stream.Stream;
@@ -421,14 +422,14 @@ void getRequestMetadata_shouldInvalidateAccessTokenWhenScoped_newAccessTokenFrom
421422

422423
@Test
423424
void getRequestMetadata_multipleCalls_usesCachedToken() throws IOException {
424-
final int[] requestCount = new int[1];
425+
final AtomicInteger requestCount = new AtomicInteger(0);
425426
MockMetadataServerTransportFactory transportFactory = new MockMetadataServerTransportFactory();
426427
transportFactory.transport =
427428
new MockMetadataServerTransport(SCOPE_TO_ACCESS_TOKEN_MAP) {
428429
@Override
429430
public LowLevelHttpRequest buildRequest(String method, String url) throws IOException {
430431
if (url.startsWith(ComputeEngineCredentials.getTokenServerEncodedUrl())) {
431-
requestCount[0]++;
432+
requestCount.incrementAndGet();
432433
}
433434
return super.buildRequest(method, url);
434435
}
@@ -440,11 +441,11 @@ public LowLevelHttpRequest buildRequest(String method, String url) throws IOExce
440441

441442
Map<String, List<String>> metadata = credentials.getRequestMetadata(CALL_URI);
442443
TestUtils.assertContainsBearerToken(metadata, ACCESS_TOKEN);
443-
assertEquals(1, requestCount[0]);
444+
assertEquals(1, requestCount.get());
444445

445446
Map<String, List<String>> metadata2 = credentials.getRequestMetadata(CALL_URI);
446447
TestUtils.assertContainsBearerToken(metadata2, ACCESS_TOKEN);
447-
assertEquals(1, requestCount[0]);
448+
assertEquals(1, requestCount.get());
448449
}
449450

450451
@Test

0 commit comments

Comments
 (0)