Revert "fix: Handle null server address"

Author: blakeli0

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/rpc/EndpointContext.java

@@ -134,7 +134,6 @@ public static EndpointContext getDefaultInstance() {
 
   public abstract String resolvedEndpoint();
 
-  @Nullable
   public abstract String resolvedServerAddress();
 
   @Nullable
@@ -411,7 +410,7 @@ private Integer parseServerPort(String endpoint) {
         return null;
       }
       HostAndPort hostAndPort = parseServerHostAndPort(endpoint);
-      if (hostAndPort == null || !hostAndPort.hasPort()) {
+      if (!hostAndPort.hasPort()) {
         return null;
       }
       return hostAndPort.getPort();
@@ -467,13 +466,8 @@ public EndpointContext build() throws IOException {
       setResolvedUniverseDomain(determineUniverseDomain());
       String endpoint = determineEndpoint();
       setResolvedEndpoint(endpoint);
-      try {
-        setResolvedServerAddress(parseServerAddress(resolvedEndpoint()));
-        setResolvedServerPort(parseServerPort(resolvedEndpoint()));
-      } catch (Exception throwable) {
-        // Server address and server port are only used for observability.
-        // We should ignore any errors parsing them and not affect the main client requests.
-      }
+      setResolvedServerAddress(parseServerAddress(resolvedEndpoint()));
+      setResolvedServerPort(parseServerPort(resolvedEndpoint()));
       setUseS2A(shouldUseS2A());
       return autoBuild();
     }

sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/rpc/EndpointContextTest.java

@@ -684,18 +684,4 @@ void endpointContextBuild_resolvesPort() throws IOException {
     Truth.assertThat(endpointContext.resolvedServerPort()).isNull();
   }
 
-  @Test
-  void endpointContextBuild_resolvesInvalidEndpointAndPort() throws Exception {
-
-    String endpoint = "localhost:-1";
-
-    EndpointContext endpointContext =
-        defaultEndpointContextBuilder
-            .setClientSettingsEndpoint(endpoint)
-            .setTransportChannelProviderEndpoint(null)
-            .build();
-
-    Truth.assertThat(endpointContext.resolvedServerAddress()).isNull();
-    Truth.assertThat(endpointContext.resolvedServerPort()).isNull();
-  }
 }