Skip to content

Commit 381405a

Browse files
committed
test: Remove redundant assertTrue assertions in LoggingTracerTest
1 parent 31f8c9a commit 381405a

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/LoggingTracerTest.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
package com.google.api.gax.tracing;
3232

3333
import static org.junit.jupiter.api.Assertions.assertEquals;
34-
import static org.junit.jupiter.api.Assertions.assertTrue;
3534

3635
import com.google.api.gax.logging.TestLogger;
3736
import com.google.api.gax.rpc.ApiExceptionFactory;
@@ -121,8 +120,6 @@ void testRecordActionableError_logsStatus() {
121120
tracer.recordActionableError(error);
122121

123122
Map<String, ?> attributesMap = getAttributesMap();
124-
125-
assertTrue(attributesMap != null && !attributesMap.isEmpty());
126123
assertEquals(
127124
"INVALID_ARGUMENT",
128125
attributesMap.get(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE));
@@ -138,8 +135,6 @@ void testRecordActionableError_logsAttributes() {
138135
tracer.recordActionableError(error);
139136

140137
Map<String, ?> attributesMap = getAttributesMap();
141-
142-
assertTrue(attributesMap != null && !attributesMap.isEmpty());
143138
assertEquals(
144139
"test-service", attributesMap.get(ObservabilityAttributes.GCP_CLIENT_SERVICE_ATTRIBUTE));
145140
}
@@ -172,8 +167,6 @@ void testRecordActionableError_logsErrorInfo() {
172167
tracer.recordActionableError(error);
173168

174169
Map<String, ?> attributesMap = getAttributesMap();
175-
176-
assertTrue(attributesMap != null && !attributesMap.isEmpty());
177170
assertEquals("TEST_REASON", attributesMap.get(ObservabilityAttributes.ERROR_TYPE_ATTRIBUTE));
178171
assertEquals(
179172
"test.domain.com", attributesMap.get(ObservabilityAttributes.ERROR_DOMAIN_ATTRIBUTE));
@@ -191,8 +184,6 @@ void testRecordActionableError_logsExceptionDetails() {
191184
tracer.recordActionableError(error);
192185

193186
Map<String, ?> attributesMap = getAttributesMap();
194-
195-
assertTrue(attributesMap != null && !attributesMap.isEmpty());
196187
assertEquals(
197188
"java.lang.RuntimeException",
198189
attributesMap.get(ObservabilityAttributes.EXCEPTION_TYPE_ATTRIBUTE));
@@ -217,8 +208,6 @@ void testRecordActionableError_logsHttpStatus() {
217208
tracer.recordActionableError(error);
218209

219210
Map<String, ?> attributesMap = getAttributesMap();
220-
221-
assertTrue(attributesMap != null && !attributesMap.isEmpty());
222211
assertEquals(
223212
"INVALID_ARGUMENT",
224213
attributesMap.get(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE));

0 commit comments

Comments
 (0)