Skip to content

Commit 3ab8fd8

Browse files
authored
chore(bigquery-jdbc): remove '-it' option from non-interactive docker commands (#13823)
1 parent d5e705b commit 3ab8fd8

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

java-bigquery-jdbc/Makefile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ run-it-standalone:
7878

7979
# Commands for dockerized environments
8080
.docker-run: |
81-
docker run -it \
81+
docker run \
82+
$(DOCKER_INTERACTIVE_OPTS) \
8283
--cap-add=NET_ADMIN \
8384
-v $(GOOGLE_APPLICATION_CREDENTIALS):/auth/application_creds.json \
8485
-v "$(GOOGLE_APPLICATION_CREDENTIALS).p12":/auth/application_creds.p12 \
@@ -98,10 +99,10 @@ docker-proxy-build:
9899
docker build --target proxy -t $(PROXY_CONTAINER_NAME) -f Dockerfile --build-arg BRANCH=${BUILD_BRANCH} $(SRC)
99100

100101
docker-session:
101-
$(MAKE) .docker-run args="bash"
102+
$(MAKE) .docker-run args="bash" DOCKER_INTERACTIVE_OPTS="-it"
102103

103104
docker-proxy-session:
104-
$(MAKE) .docker-run CONTAINER_NAME=$(PROXY_CONTAINER_NAME) args="bash"
105+
$(MAKE) .docker-run CONTAINER_NAME=$(PROXY_CONTAINER_NAME) args="bash" DOCKER_INTERACTIVE_OPTS="-it"
105106

106107
docker-package-all-dependencies: docker-build
107108
mkdir -p $(PACKAGE_DESTINATION)

0 commit comments

Comments
 (0)