test(logging): re-enable ITSinkTest and scope sink cleanup to test prefix

Fixes b/482174880 (GitHub Issue #11906) by ensuring setUp() only cleans up leaked test sinks matching TEST_SINK_PREFIX, avoiding PERMISSION_DENIED errors on immutable built-in system sinks (_Required, _Default). Also wraps test verification logic in try...finally blocks for robust self-cleanup.

BUG=b/482174880
TAG=agy
CONV=d4a74f94-579a-4c3f-96c3-f90fcbc6c699

Author: lqiu96

java-logging/google-cloud-logging/src/test/java/com/google/cloud/logging/it/ITSinkTest.java

@@ -34,11 +34,12 @@
 import java.util.Iterator;
 import java.util.Set;
 import org.junit.BeforeClass;
-import org.junit.Ignore;
 import org.junit.Test;
 
 public class ITSinkTest extends BaseSystemTest {
 
+  private static final String TEST_SINK_PREFIX = "test-";
+
   @BeforeClass
   public static void setUp() {
     // Cleanup all stucked sinks if any
@@ -47,6 +48,9 @@ public static void setUp() {
     Iterator<Sink> iterator = sinkPage.iterateAll().iterator();
     while (iterator.hasNext()) {
       Sink sink = iterator.next();
+      if (!sink.getName().startsWith(TEST_SINK_PREFIX)) {
+        continue;
+      }
       try {
         sink.delete();
       } catch (Exception ex) {
@@ -56,7 +60,6 @@ public static void setUp() {
   }
 
   @Test
-  @Ignore
   public void testCreateGetUpdateAndDeleteSink() {
     String name = formatForTest("test-create-get-update-sink");
     SinkInfo sinkInfo =
@@ -65,19 +68,23 @@ public void testCreateGetUpdateAndDeleteSink() {
             .setVersionFormat(SinkInfo.VersionFormat.V2)
             .build();
     Sink sink = logging.create(sinkInfo);
-    assertEquals(name, sink.getName());
-    assertEquals(SinkInfo.VersionFormat.V2, sink.getVersionFormat());
-    assertEquals("severity>=ERROR", sink.getFilter());
-    SinkInfo.Destination.DatasetDestination datasetDestination = sink.getDestination();
-    assertEquals(logging.getOptions().getProjectId(), datasetDestination.getProject());
-    assertEquals("dataset", datasetDestination.getDataset());
-    assertEquals(sink, logging.getSink(name));
-    sink = sink.toBuilder().setFilter("severity<=ERROR").build().update();
-    assertEquals(name, sink.getName());
-    assertEquals(SinkInfo.VersionFormat.V2, sink.getVersionFormat());
-    assertEquals("severity<=ERROR", sink.getFilter());
-    assertTrue(sink.delete());
-    assertFalse(sink.delete());
+    try {
+      assertEquals(name, sink.getName());
+      assertEquals(SinkInfo.VersionFormat.V2, sink.getVersionFormat());
+      assertEquals("severity>=ERROR", sink.getFilter());
+      SinkInfo.Destination.DatasetDestination datasetDestination = sink.getDestination();
+      assertEquals(logging.getOptions().getProjectId(), datasetDestination.getProject());
+      assertEquals("dataset", datasetDestination.getDataset());
+      assertEquals(sink, logging.getSink(name));
+      sink = sink.toBuilder().setFilter("severity<=ERROR").build().update();
+      assertEquals(name, sink.getName());
+      assertEquals(SinkInfo.VersionFormat.V2, sink.getVersionFormat());
+      assertEquals("severity<=ERROR", sink.getFilter());
+      assertTrue(sink.delete());
+      assertFalse(sink.delete());
+    } finally {
+      logging.deleteSink(name);
+    }
   }
 
   @Test