Skip to content

Commit 408abdb

Browse files
committed
test: prevent root versions.txt from affecting postprocessor test fixtures
After the monorepo migration, the shared versions.txt at the root caused Release Please to mutate test fixtures named pom.xml, breaking the postprocessor unit test. - Added -golden suffix to version markers in test resources to isolate them from Release Please scanning. Fixes #12841
1 parent 3a352fe commit 408abdb

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

  • sdk-platform-java/hermetic_build/library_generation/tests/resources/test_monorepo_postprocessing
    • java-dns
    • java-service-control/google-cloud-service-control-bom
    • java-tasks/google-cloud-tasks-bom

sdk-platform-java/hermetic_build/library_generation/tests/resources/test_monorepo_postprocessing/java-dns/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
<groupId>com.google.cloud</groupId>
55
<artifactId>google-cloud-dns</artifactId>
66
<packaging>jar</packaging>
7-
<version>2.33.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-dns:current} -->
7+
<version>2.33.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-dns-golden:current} -->
88
<name>Google Cloud DNS Parent</name>
99
</project>

sdk-platform-java/hermetic_build/library_generation/tests/resources/test_monorepo_postprocessing/java-service-control/google-cloud-service-control-bom/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>com.google.cloud</groupId>
55
<artifactId>google-cloud-service-control-bom</artifactId>
6-
<version>1.35.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-service-control:current} -->
6+
<version>1.35.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-service-control-golden:current} -->
77
<packaging>pom</packaging>
88
</project>

sdk-platform-java/hermetic_build/library_generation/tests/resources/test_monorepo_postprocessing/java-tasks/google-cloud-tasks-bom/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>com.google.cloud</groupId>
55
<artifactId>google-cloud-tasks-bom</artifactId>
6-
<version>2.35.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-tasks:current} -->
6+
<version>2.35.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-tasks-golden:current} -->
77
<packaging>pom</packaging>
88
</project>

0 commit comments

Comments
 (0)