Skip to content

Commit 40ee3ae

Browse files
committed
chore: Fix ITGdch tests
1 parent af57081 commit 40ee3ae

File tree

5 files changed

+19
-17
lines changed

5 files changed

+19
-17
lines changed

sdk-platform-java/java-showcase-3.21.0/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITGdch.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,9 @@ void testCreateClient_withGdchCredentialAndNoAudience_defaultsToEndpointBasedAud
156156
NullPointerException expectedEx =
157157
assertThrows(NullPointerException.class, () -> initialCredentials.refresh());
158158
assertTrue(
159-
expectedEx.getMessage().contains("Audience are not configured for GDCH service account"));
159+
expectedEx
160+
.getMessage()
161+
.contains("Audience cannot be null or empty for GDCH service account credentials"));
160162

161163
// However, the credentials prepared in ClientContext should be able to refresh since the
162164
// audience would be
@@ -201,7 +203,7 @@ void testCreateClient_withGdchCredentialWithValidAudience_usesCredentialWithPass
201203
assertTrue(
202204
thrownByClientCreds
203205
.getMessage()
204-
.contains("Audience are not configured for GDCH service account"));
206+
.contains("Audience cannot be null or empty for GDCH service account credentials"));
205207

206208
// But the credentials prepared in ClientContext should be able to refresh since the audience
207209
// would be internally

sdk-platform-java/java-showcase-3.21.0/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/util/InterceptingMockTokenServerTransport.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@
1818

1919
import com.google.api.client.http.LowLevelHttpRequest;
2020
import com.google.api.client.json.JsonFactory;
21+
import com.google.api.client.json.JsonParser;
2122
import com.google.api.client.json.gson.GsonFactory;
22-
import com.google.api.client.json.webtoken.JsonWebSignature;
2323
import com.google.api.client.testing.http.MockLowLevelHttpRequest;
24-
import com.google.auth.TestUtils;
2524
import com.google.auth.oauth2.MockTokenServerTransport;
2625
import java.io.IOException;
2726
import java.util.Map;
@@ -39,10 +38,8 @@ public LowLevelHttpRequest buildRequest(String method, String url) throws IOExce
3938

4039
public String getLastAudienceSent() throws IOException {
4140
String contentString = lastRequest.getContentAsString();
42-
Map<String, String> query = TestUtils.parseQuery(contentString);
43-
String assertion = query.get("assertion");
44-
JsonWebSignature signature = JsonWebSignature.parse(JSON_FACTORY, assertion);
45-
String foundTargetAudience = (String) signature.getPayload().get("api_audience");
46-
return foundTargetAudience;
41+
JsonParser jsonParser = JSON_FACTORY.createJsonParser(contentString);
42+
Map<String, Object> json = jsonParser.parseAndClose(Map.class);
43+
return (String) json.get("audience");
4744
}
4845
}

sdk-platform-java/java-showcase-3.25.8/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITGdch.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,9 @@ void testCreateClient_withGdchCredentialAndNoAudience_defaultsToEndpointBasedAud
156156
NullPointerException expectedEx =
157157
assertThrows(NullPointerException.class, () -> initialCredentials.refresh());
158158
assertTrue(
159-
expectedEx.getMessage().contains("Audience are not configured for GDCH service account"));
159+
expectedEx
160+
.getMessage()
161+
.contains("Audience cannot be null or empty for GDCH service account credentials"));
160162

161163
// However, the credentials prepared in ClientContext should be able to refresh since the
162164
// audience would be
@@ -201,7 +203,7 @@ void testCreateClient_withGdchCredentialWithValidAudience_usesCredentialWithPass
201203
assertTrue(
202204
thrownByClientCreds
203205
.getMessage()
204-
.contains("Audience are not configured for GDCH service account"));
206+
.contains("Audience cannot be null or empty for GDCH service account credentials"));
205207

206208
// But the credentials prepared in ClientContext should be able to refresh since the audience
207209
// would be internally

sdk-platform-java/java-showcase-3.25.8/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/util/InterceptingMockTokenServerTransport.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import com.google.api.client.http.LowLevelHttpRequest;
2020
import com.google.api.client.json.JsonFactory;
21+
import com.google.api.client.json.JsonParser;
2122
import com.google.api.client.json.gson.GsonFactory;
2223
import com.google.api.client.json.webtoken.JsonWebSignature;
2324
import com.google.api.client.testing.http.MockLowLevelHttpRequest;
@@ -39,10 +40,8 @@ public LowLevelHttpRequest buildRequest(String method, String url) throws IOExce
3940

4041
public String getLastAudienceSent() throws IOException {
4142
String contentString = lastRequest.getContentAsString();
42-
Map<String, String> query = TestUtils.parseQuery(contentString);
43-
String assertion = query.get("assertion");
44-
JsonWebSignature signature = JsonWebSignature.parse(JSON_FACTORY, assertion);
45-
String foundTargetAudience = (String) signature.getPayload().get("api_audience");
46-
return foundTargetAudience;
43+
JsonParser jsonParser = JSON_FACTORY.createJsonParser(contentString);
44+
Map<String, Object> json = jsonParser.parseAndClose(Map.class);
45+
return (String) json.get("audience");
4746
}
4847
}

sdk-platform-java/java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/util/InterceptingMockTokenServerTransport.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import com.google.api.client.http.LowLevelHttpRequest;
2020
import com.google.api.client.json.JsonFactory;
21+
import com.google.api.client.json.JsonParser;
2122
import com.google.api.client.json.gson.GsonFactory;
2223
import com.google.api.client.json.webtoken.JsonWebSignature;
2324
import com.google.api.client.testing.http.MockLowLevelHttpRequest;
@@ -39,7 +40,8 @@ public LowLevelHttpRequest buildRequest(String method, String url) throws IOExce
3940

4041
public String getLastAudienceSent() throws IOException {
4142
String contentString = lastRequest.getContentAsString();
42-
Map<String, Object> json = JSON_FACTORY.createJsonParser(contentString).parse(Map.class);
43+
JsonParser jsonParser = JSON_FACTORY.createJsonParser(contentString);
44+
Map<String, Object> json = jsonParser.parseAndClose(Map.class);
4345
return (String) json.get("audience");
4446
}
4547
}

0 commit comments

Comments
 (0)