Skip to content

Commit 413cbf8

Browse files
committed
refactor(bigtable-snippets): shorten ByteString references and add missing imports
1 parent 1fa07aa commit 413cbf8

4 files changed

Lines changed: 10 additions & 8 deletions

File tree

java-bigtable/samples/snippets/src/main/java/com/example/bigtable/AuthorizedViewExample.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -174,12 +174,11 @@ public void createAuthorizedView() {
174174
try {
175175
AuthorizedView.SubsetView subsetView =
176176
AuthorizedView.SubsetView.newBuilder()
177-
.addRowPrefixes(com.google.protobuf.ByteString.EMPTY)
177+
.addRowPrefixes(ByteString.EMPTY)
178178
.putFamilySubsets(
179179
COLUMN_FAMILY,
180180
AuthorizedView.FamilySubsets.newBuilder()
181-
.addQualifierPrefixes(
182-
com.google.protobuf.ByteString.copyFromUtf8(COLUMN_QUALIFIER_NAME))
181+
.addQualifierPrefixes(ByteString.copyFromUtf8(COLUMN_QUALIFIER_NAME))
183182
.build())
184183
.build();
185184
AuthorizedView authorizedViewObj =
@@ -208,11 +207,11 @@ public void updateAuthorizedView() {
208207
// Update to an authorized view permitting everything.
209208
AuthorizedView.SubsetView subsetView =
210209
AuthorizedView.SubsetView.newBuilder()
211-
.addRowPrefixes(com.google.protobuf.ByteString.EMPTY)
210+
.addRowPrefixes(ByteString.EMPTY)
212211
.putFamilySubsets(
213212
COLUMN_FAMILY,
214213
AuthorizedView.FamilySubsets.newBuilder()
215-
.addQualifierPrefixes(com.google.protobuf.ByteString.EMPTY)
214+
.addQualifierPrefixes(ByteString.EMPTY)
216215
.build())
217216
.build();
218217
AuthorizedView authorizedViewObj =

java-bigtable/samples/snippets/src/main/java/com/example/bigtable/deletes/DropRowRangeExample.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
// [START bigtable_drop_row_range]
2020
import com.google.bigtable.admin.v2.DropRowRangeRequest;
2121
import com.google.cloud.bigtable.admin.v2.BigtableTableAdminClientV2;
22+
import com.google.protobuf.ByteString;
2223
import java.io.IOException;
2324

2425
public class DropRowRangeExample {
@@ -27,7 +28,7 @@ public void dropRowRange(String projectId, String instanceId, String tableId) th
2728
DropRowRangeRequest request =
2829
DropRowRangeRequest.newBuilder()
2930
.setName("projects/" + projectId + "/instances/" + instanceId + "/tables/" + tableId)
30-
.setRowKeyPrefix(com.google.protobuf.ByteString.copyFromUtf8("phone#4c410523"))
31+
.setRowKeyPrefix(ByteString.copyFromUtf8("phone#4c410523"))
3132
.build();
3233
tableAdminClient.dropRowRange(request);
3334
}

java-bigtable/samples/snippets/src/test/java/com/example/bigtable/AuthorizedViewExampleTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import com.google.cloud.bigtable.data.v2.models.AuthorizedViewId;
3737
import com.google.cloud.bigtable.data.v2.models.Row;
3838
import com.google.cloud.bigtable.data.v2.models.RowCell;
39+
import com.google.protobuf.ByteString;
3940
import java.io.IOException;
4041
import java.util.ArrayList;
4142
import java.util.Arrays;
@@ -108,11 +109,11 @@ public void setup() throws Exception {
108109

109110
AuthorizedView.SubsetView subsetView =
110111
AuthorizedView.SubsetView.newBuilder()
111-
.addRowPrefixes(com.google.protobuf.ByteString.EMPTY)
112+
.addRowPrefixes(ByteString.EMPTY)
112113
.putFamilySubsets(
113114
COLUMN_FAMILY,
114115
AuthorizedView.FamilySubsets.newBuilder()
115-
.addQualifierPrefixes(com.google.protobuf.ByteString.EMPTY)
116+
.addQualifierPrefixes(ByteString.EMPTY)
116117
.build())
117118
.build();
118119
AuthorizedView authorizedViewObj =

java-bigtable/samples/snippets/src/test/java/com/example/bigtable/TableAdminExampleTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import static org.junit.Assert.assertFalse;
2121
import static org.junit.Assert.assertTrue;
2222

23+
import com.google.api.gax.rpc.NotFoundException;
2324
import com.google.bigtable.admin.v2.ColumnFamily;
2425
import com.google.bigtable.admin.v2.CreateTableRequest;
2526
import com.google.bigtable.admin.v2.GetTableRequest;

0 commit comments

Comments
 (0)