Commit 435dd8c
authored
fix: Handle null server address (#12184)
In case of an invalid endpoint such as `localhost:-1`, the current
parsing logic returns null for server address. This PR made server
address nullable. And added a null check for the port parsing.
In addition, added a try catch for the whole parsing logic because
serviceAddress and serverPort should only be used for obersevability and
should not affect regular requests.1 parent a7c92e0 commit 435dd8c
File tree
2 files changed
+24
-3
lines changed- sdk-platform-java/gax-java/gax/src
- main/java/com/google/api/gax/rpc
- test/java/com/google/api/gax/rpc
2 files changed
+24
-3
lines changedLines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| 137 | + | |
137 | 138 | | |
138 | 139 | | |
139 | 140 | | |
| |||
410 | 411 | | |
411 | 412 | | |
412 | 413 | | |
413 | | - | |
| 414 | + | |
414 | 415 | | |
415 | 416 | | |
416 | 417 | | |
| |||
466 | 467 | | |
467 | 468 | | |
468 | 469 | | |
469 | | - | |
470 | | - | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
471 | 477 | | |
472 | 478 | | |
473 | 479 | | |
| |||
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
683 | 683 | | |
684 | 684 | | |
685 | 685 | | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
686 | 701 | | |
0 commit comments