Skip to content

Commit 4e94b66

Browse files
ldetmerldetmer
committed
replaced all string concat with StringBuilder
1 parent e9b4453 commit 4e94b66

File tree

1 file changed

+59
-11
lines changed
  • java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2

1 file changed

+59
-11
lines changed

‎java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java‎

Lines changed: 59 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,12 @@ public Tuple<String, Iterable<Dataset>> listDatasetsSkipExceptionTranslation(
230230
.getRequestHeaders()
231231
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
232232

233-
String gcpResourceDestinationId = RESOURCE_PROJECT_PREFIX + projectId + "/datasets";
233+
String gcpResourceDestinationId =
234+
new StringBuilder()
235+
.append(RESOURCE_PROJECT_PREFIX)
236+
.append(projectId)
237+
.append("/datasets")
238+
.toString();
234239

235240
return executeWithSpan(
236241
createRpcTracingSpan(
@@ -438,7 +443,12 @@ public Job createSkipExceptionTranslation(Job job, Map<Option, ?> options) throw
438443
.getRequestHeaders()
439444
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
440445

441-
String gcpResourceDestinationId = RESOURCE_PROJECT_PREFIX + projectId + "/jobs";
446+
String gcpResourceDestinationId =
447+
new StringBuilder()
448+
.append(RESOURCE_PROJECT_PREFIX)
449+
.append(projectId)
450+
.append("/jobs")
451+
.toString();
442452

443453
return executeWithSpan(
444454
createRpcTracingSpan(
@@ -481,7 +491,12 @@ public Job createJobForQuerySkipExceptionTranslation(Job job) throws IOException
481491
.getRequestHeaders()
482492
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
483493

484-
String gcpResourceDestinationId = RESOURCE_PROJECT_PREFIX + projectId + "/jobs";
494+
String gcpResourceDestinationId =
495+
new StringBuilder()
496+
.append(RESOURCE_PROJECT_PREFIX)
497+
.append(projectId)
498+
.append("/jobs")
499+
.toString();
485500

486501
return executeWithSpan(
487502
createRpcTracingSpan(
@@ -750,7 +765,13 @@ public Tuple<String, Iterable<Table>> listTablesSkipExceptionTranslation(
750765
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
751766

752767
String gcpResourceDestinationId =
753-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/tables";
768+
new StringBuilder()
769+
.append(RESOURCE_PROJECT_PREFIX)
770+
.append(projectId)
771+
.append("/datasets/")
772+
.append(datasetId)
773+
.append("/tables")
774+
.toString();
754775

755776
return executeWithSpan(
756777
createRpcTracingSpan(
@@ -1034,7 +1055,14 @@ public boolean deleteModelSkipExceptionTranslation(
10341055
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
10351056

10361057
String gcpResourceDestinationId =
1037-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/models/" + modelId;
1058+
new StringBuilder()
1059+
.append(RESOURCE_PROJECT_PREFIX)
1060+
.append(projectId)
1061+
.append("/datasets/")
1062+
.append(datasetId)
1063+
.append("/models/")
1064+
.append(modelId)
1065+
.toString();
10381066

10391067
return executeWithSpan(
10401068
createRpcTracingSpan(
@@ -1245,7 +1273,14 @@ public boolean deleteRoutineSkipExceptionTranslation(
12451273
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
12461274

12471275
String gcpResourceDestinationId =
1248-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/routines/" + routineId;
1276+
new StringBuilder()
1277+
.append(RESOURCE_PROJECT_PREFIX)
1278+
.append(projectId)
1279+
.append("/datasets/")
1280+
.append(datasetId)
1281+
.append("/routines/")
1282+
.append(routineId)
1283+
.toString();
12491284

12501285
return executeWithSpan(
12511286
createRpcTracingSpan(
@@ -1564,7 +1599,12 @@ public Tuple<String, Iterable<Job>> listJobsSkipExceptionTranslation(
15641599
.getRequestHeaders()
15651600
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
15661601

1567-
String gcpResourceDestinationId = RESOURCE_PROJECT_PREFIX + projectId + "/jobs";
1602+
String gcpResourceDestinationId =
1603+
new StringBuilder()
1604+
.append(RESOURCE_PROJECT_PREFIX)
1605+
.append(projectId)
1606+
.append("/jobs")
1607+
.toString();
15681608

15691609
return executeWithSpan(
15701610
createRpcTracingSpan(
@@ -1822,7 +1862,12 @@ public QueryResponse queryRpcSkipExceptionTranslation(String projectId, QueryReq
18221862
.getRequestHeaders()
18231863
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
18241864

1825-
String gcpResourceDestinationId = RESOURCE_PROJECT_PREFIX + projectId + "/jobs";
1865+
String gcpResourceDestinationId =
1866+
new StringBuilder()
1867+
.append(RESOURCE_PROJECT_PREFIX)
1868+
.append(projectId)
1869+
.append("/jobs")
1870+
.toString();
18261871

18271872
return executeWithSpan(
18281873
createRpcTracingSpan(
@@ -1952,7 +1997,8 @@ public Policy getIamPolicySkipExceptionTranslation(String resourceId, Map<Option
19521997
.getRequestHeaders()
19531998
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
19541999

1955-
String gcpResourceDestinationId = "//bigquery.googleapis.com/" + resourceId;
2000+
String gcpResourceDestinationId =
2001+
new StringBuilder().append("//bigquery.googleapis.com/").append(resourceId).toString();
19562002

19572003
return executeWithSpan(
19582004
createRpcTracingSpan(
@@ -1987,7 +2033,8 @@ public Policy setIamPolicySkipExceptionTranslation(
19872033
.getRequestHeaders()
19882034
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
19892035

1990-
String gcpResourceDestinationId = "//bigquery.googleapis.com/" + resourceId;
2036+
String gcpResourceDestinationId =
2037+
new StringBuilder().append("//bigquery.googleapis.com/").append(resourceId).toString();
19912038

19922039
return executeWithSpan(
19932040
createRpcTracingSpan(
@@ -2023,7 +2070,8 @@ public TestIamPermissionsResponse testIamPermissionsSkipExceptionTranslation(
20232070
.getRequestHeaders()
20242071
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
20252072

2026-
String gcpResourceDestinationId = "//bigquery.googleapis.com/" + resourceId;
2073+
String gcpResourceDestinationId =
2074+
new StringBuilder().append("//bigquery.googleapis.com/").append(resourceId).toString();
20272075

20282076
return executeWithSpan(
20292077
createRpcTracingSpan(

0 commit comments

Comments
 (0)