Skip to content

Commit 51960b2

Browse files
committed
test(showcase): use lower bounds only for retry delays to prevent flakiness
1 parent eb5cf39 commit 51960b2

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

  • java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it

java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITRetries.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -169,21 +169,18 @@ private void verifySequenceReport(SequenceReport report) {
169169
.isEqualTo(com.google.rpc.Code.UNAVAILABLE.getNumber());
170170
assertThat(attempts.get(3).getStatus().getCode()).isEqualTo(com.google.rpc.Code.OK.getNumber());
171171

172-
// Verify delay intervals are within expected tolerances:
173-
// Attempt 1 -> 2: ~100ms delay. Range [80ms, 250ms]
172+
// Verify delay intervals are at least the expected exponential backoff thresholds:
173+
// Attempt 1 -> 2: scheduled 100ms. Must be at least 80ms (no upper bound)
174174
long delay1 = getDelayMs(attempts.get(1));
175175
assertThat(delay1).isAtLeast(80L);
176-
assertThat(delay1).isLessThan(250L);
177176

178-
// Attempt 2 -> 3: ~200ms delay. Range [180ms, 400ms]
177+
// Attempt 2 -> 3: scheduled 200ms. Must be at least 180ms (no upper bound)
179178
long delay2 = getDelayMs(attempts.get(2));
180179
assertThat(delay2).isAtLeast(180L);
181-
assertThat(delay2).isLessThan(400L);
182180

183-
// Attempt 3 -> 4: ~400ms delay. Range [380ms, 700ms]
181+
// Attempt 3 -> 4: scheduled 400ms. Must be at least 380ms (no upper bound)
184182
long delay3 = getDelayMs(attempts.get(3));
185183
assertThat(delay3).isAtLeast(380L);
186-
assertThat(delay3).isLessThan(700L);
187184
}
188185

189186
private long getDelayMs(SequenceReport.Attempt attempt) {

0 commit comments

Comments
 (0)