fix(gax): add assertion to test

whowes · whowes · commit 54b9310abbb3 · 2026-05-20T20:40:19.000Z
diff --git a/sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/retrying/RetryAlgorithmTest.java b/sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/retrying/RetryAlgorithmTest.java
@@ -213,8 +213,10 @@ void testShouldRetry_resultFalseAndThrowableNotNull_callsTimed() {
     TimedAttemptSettings previousSettings = mock(TimedAttemptSettings.class);
     when(resultAlgorithm.shouldRetry(previousThrowable, previousResult)).thenReturn(false);
 
-    algorithm.shouldRetry(previousThrowable, previousResult, previousSettings);
+    boolean shouldRetry =
+        algorithm.shouldRetry(previousThrowable, previousResult, previousSettings);
 
+    assertFalse(shouldRetry);
     verify(timedAlgorithm).shouldRetry(previousSettings);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -213,8 +213,10 @@ void testShouldRetry_resultFalseAndThrowableNotNull_callsTimed() {`
`213`	`213`	`TimedAttemptSettings previousSettings = mock(TimedAttemptSettings.class);`
`214`	`214`	`when(resultAlgorithm.shouldRetry(previousThrowable, previousResult)).thenReturn(false);`
`215`	`215`
`216`		`- algorithm.shouldRetry(previousThrowable, previousResult, previousSettings);`
	`216`	`+ boolean shouldRetry =`
	`217`	`+ algorithm.shouldRetry(previousThrowable, previousResult, previousSettings);`
`217`	`218`
	`219`	`+ assertFalse(shouldRetry);`
`218`	`220`	`verify(timedAlgorithm).shouldRetry(previousSettings);`
`219`	`221`	`}`
`220`	`222`