Skip to content

Commit 54f4169

Browse files
ldetmerldetmer
committed
missed some updates to use stringbuilder
1 parent 2e69446 commit 54f4169

1 file changed

Lines changed: 112 additions & 25 deletions

File tree

  • java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2

‎java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java‎

Lines changed: 112 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -867,12 +867,14 @@ public Model patchSkipExceptionTranslation(Model model, Map<Option, ?> options)
867867
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
868868

869869
String destinationId =
870-
RESOURCE_PROJECT_PREFIX
871-
+ reference.getProjectId()
872-
+ "/datasets/"
873-
+ reference.getDatasetId()
874-
+ "/models/"
875-
+ reference.getModelId();
870+
new StringBuilder()
871+
.append(RESOURCE_PROJECT_PREFIX)
872+
.append(reference.getProjectId())
873+
.append("/datasets/")
874+
.append(reference.getDatasetId())
875+
.append("/models/")
876+
.append(reference.getModelId())
877+
.toString();
876878

877879
return executeWithSpan(
878880
createRpcTracingSpan(
@@ -922,7 +924,14 @@ public Model getModelSkipExceptionTranslation(
922924
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
923925

924926
String destinationId =
925-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/models/" + modelId;
927+
new StringBuilder()
928+
.append(RESOURCE_PROJECT_PREFIX)
929+
.append(projectId)
930+
.append("/datasets/")
931+
.append(datasetId)
932+
.append("/models/")
933+
.append(modelId)
934+
.toString();
926935

927936
return executeWithSpan(
928937
createRpcTracingSpan(
@@ -968,7 +977,13 @@ public Tuple<String, Iterable<Model>> listModelsSkipExceptionTranslation(
968977
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
969978

970979
String destinationId =
971-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/models";
980+
new StringBuilder()
981+
.append(RESOURCE_PROJECT_PREFIX)
982+
.append(projectId)
983+
.append("/datasets/")
984+
.append(datasetId)
985+
.append("/models")
986+
.toString();
972987

973988
return executeWithSpan(
974989
createRpcTracingSpan(
@@ -1064,12 +1079,14 @@ public Routine updateSkipExceptionTranslation(Routine routine, Map<Option, ?> op
10641079
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
10651080

10661081
String destinationId =
1067-
RESOURCE_PROJECT_PREFIX
1068-
+ reference.getProjectId()
1069-
+ "/datasets/"
1070-
+ reference.getDatasetId()
1071-
+ "/routines/"
1072-
+ reference.getRoutineId();
1082+
new StringBuilder()
1083+
.append(RESOURCE_PROJECT_PREFIX)
1084+
.append(reference.getProjectId())
1085+
.append("/datasets/")
1086+
.append(reference.getDatasetId())
1087+
.append("/routines/")
1088+
.append(reference.getRoutineId())
1089+
.toString();
10731090

10741091
return executeWithSpan(
10751092
createRpcTracingSpan(
@@ -1119,7 +1136,14 @@ public Routine getRoutineSkipExceptionTranslation(
11191136
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
11201137

11211138
String destinationId =
1122-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/routines/" + routineId;
1139+
new StringBuilder()
1140+
.append(RESOURCE_PROJECT_PREFIX)
1141+
.append(projectId)
1142+
.append("/datasets/")
1143+
.append(datasetId)
1144+
.append("/routines/")
1145+
.append(routineId)
1146+
.toString();
11231147

11241148
return executeWithSpan(
11251149
createRpcTracingSpan(
@@ -1165,7 +1189,13 @@ public Tuple<String, Iterable<Routine>> listRoutinesSkipExceptionTranslation(
11651189
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
11661190

11671191
String destinationId =
1168-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/routines";
1192+
new StringBuilder()
1193+
.append(RESOURCE_PROJECT_PREFIX)
1194+
.append(projectId)
1195+
.append("/datasets/")
1196+
.append(datasetId)
1197+
.append("/routines")
1198+
.toString();
11691199

11701200
return executeWithSpan(
11711201
createRpcTracingSpan(
@@ -1256,7 +1286,14 @@ public TableDataInsertAllResponse insertAllSkipExceptionTranslation(
12561286
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
12571287

12581288
String destinationId =
1259-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/tables/" + tableId;
1289+
new StringBuilder()
1290+
.append(RESOURCE_PROJECT_PREFIX)
1291+
.append(projectId)
1292+
.append("/datasets/")
1293+
.append(datasetId)
1294+
.append("/tables/")
1295+
.append(tableId)
1296+
.toString();
12601297

12611298
return executeWithSpan(
12621299
createRpcTracingSpan(
@@ -1300,7 +1337,14 @@ public TableDataList listTableDataSkipExceptionTranslation(
13001337
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
13011338

13021339
String destinationId =
1303-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/tables/" + tableId;
1340+
new StringBuilder()
1341+
.append(RESOURCE_PROJECT_PREFIX)
1342+
.append(projectId)
1343+
.append("/datasets/")
1344+
.append(datasetId)
1345+
.append("/tables/")
1346+
.append(tableId)
1347+
.toString();
13041348

13051349
return executeWithSpan(
13061350
createRpcTracingSpan(
@@ -1354,7 +1398,14 @@ public TableDataList listTableDataWithRowLimitSkipExceptionTranslation(
13541398
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
13551399

13561400
String destinationId =
1357-
RESOURCE_PROJECT_PREFIX + projectId + "/datasets/" + datasetId + "/tables/" + tableId;
1401+
new StringBuilder()
1402+
.append(RESOURCE_PROJECT_PREFIX)
1403+
.append(projectId)
1404+
.append("/datasets/")
1405+
.append(datasetId)
1406+
.append("/tables/")
1407+
.append(tableId)
1408+
.toString();
13581409

13591410
return executeWithSpan(
13601411
createRpcTracingSpan(
@@ -1400,7 +1451,13 @@ public Job getJobSkipExceptionTranslation(
14001451
.getRequestHeaders()
14011452
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
14021453

1403-
String destinationId = RESOURCE_PROJECT_PREFIX + projectId + "/jobs/" + jobId;
1454+
String destinationId =
1455+
new StringBuilder()
1456+
.append(RESOURCE_PROJECT_PREFIX)
1457+
.append(projectId)
1458+
.append("/jobs/")
1459+
.append(jobId)
1460+
.toString();
14041461

14051462
return executeWithSpan(
14061463
createRpcTracingSpan(
@@ -1444,7 +1501,13 @@ public Job getQueryJobSkipExceptionTranslation(String projectId, String jobId, S
14441501
.getRequestHeaders()
14451502
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
14461503

1447-
String destinationId = RESOURCE_PROJECT_PREFIX + projectId + "/jobs/" + jobId;
1504+
String destinationId =
1505+
new StringBuilder()
1506+
.append(RESOURCE_PROJECT_PREFIX)
1507+
.append(projectId)
1508+
.append("/jobs/")
1509+
.append(jobId)
1510+
.toString();
14481511

14491512
return executeWithSpan(
14501513
createRpcTracingSpan(
@@ -1572,7 +1635,13 @@ public boolean cancelSkipExceptionTranslation(String projectId, String jobId, St
15721635
.getRequestHeaders()
15731636
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
15741637

1575-
String destinationId = RESOURCE_PROJECT_PREFIX + projectId + "/jobs/" + jobId;
1638+
String destinationId =
1639+
new StringBuilder()
1640+
.append(RESOURCE_PROJECT_PREFIX)
1641+
.append(projectId)
1642+
.append("/jobs/")
1643+
.append(jobId)
1644+
.toString();
15761645

15771646
return executeWithSpan(
15781647
createRpcTracingSpan(
@@ -1607,7 +1676,13 @@ public boolean deleteJobSkipExceptionTranslation(
16071676
.getRequestHeaders()
16081677
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
16091678

1610-
String destinationId = RESOURCE_PROJECT_PREFIX + projectId + "/jobs/" + jobName;
1679+
String destinationId =
1680+
new StringBuilder()
1681+
.append(RESOURCE_PROJECT_PREFIX)
1682+
.append(projectId)
1683+
.append("/jobs/")
1684+
.append(jobName)
1685+
.toString();
16111686

16121687
return executeWithSpan(
16131688
createRpcTracingSpan(
@@ -1654,7 +1729,13 @@ public GetQueryResultsResponse getQueryResultsSkipExceptionTranslation(
16541729
.getRequestHeaders()
16551730
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
16561731

1657-
String destinationId = RESOURCE_PROJECT_PREFIX + projectId + "/jobs/" + jobId;
1732+
String destinationId =
1733+
new StringBuilder()
1734+
.append(RESOURCE_PROJECT_PREFIX)
1735+
.append(projectId)
1736+
.append("/jobs/")
1737+
.append(jobId)
1738+
.toString();
16581739

16591740
return executeWithSpan(
16601741
createRpcTracingSpan(
@@ -1700,7 +1781,13 @@ public GetQueryResultsResponse getQueryResultsWithRowLimitSkipExceptionTranslati
17001781
.getRequestHeaders()
17011782
.set("x-goog-otel-enabled", this.options.isOpenTelemetryTracingEnabled());
17021783

1703-
String destinationId = RESOURCE_PROJECT_PREFIX + projectId + "/jobs/" + jobId;
1784+
String destinationId =
1785+
new StringBuilder()
1786+
.append(RESOURCE_PROJECT_PREFIX)
1787+
.append(projectId)
1788+
.append("/jobs/")
1789+
.append(jobId)
1790+
.toString();
17041791

17051792
return executeWithSpan(
17061793
createRpcTracingSpan(

0 commit comments

Comments
 (0)