Commit 57baaea
authored
fix(spanner): honor built-in metrics opt-out for gRPC metrics exporter (#12711)
Fixes: #12229
setBuiltInMetricsEnabled(false) was only disabling the Spanner API
tracer metrics path. During channel setup, the client could still
install gRPC built-in metrics/export wiring and create the Cloud
Monitoring exporter. In practice, users could
still see SpannerCloudMonitoringExporter attempts and
monitoring.timeSeries.create permission failures even though startup
logs reported:
```
Built-in metrics enabled: false
```
That behavior contradicted the documented contract that
setBuiltInMetricsEnabled(false) opts out of client-side metrics.1 parent 15faaaa commit 57baaea
File tree
2 files changed
+29
-1
lines changed- java-spanner/google-cloud-spanner/src
- main/java/com/google/cloud/spanner
- test/java/com/google/cloud/spanner/spi/v1
2 files changed
+29
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2446 | 2446 | | |
2447 | 2447 | | |
2448 | 2448 | | |
2449 | | - | |
| 2449 | + | |
2450 | 2450 | | |
2451 | 2451 | | |
2452 | 2452 | | |
| |||
Lines changed: 28 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1030 | 1030 | | |
1031 | 1031 | | |
1032 | 1032 | | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
| 1049 | + | |
| 1050 | + | |
| 1051 | + | |
| 1052 | + | |
| 1053 | + | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
1033 | 1061 | | |
1034 | 1062 | | |
1035 | 1063 | | |
| |||
0 commit comments