Skip to content

Commit 58704d5

Browse files
committed
test(bigquery): use UNNEST and maxResults to make testFastSQLQueryMultiPage hermetic and fast
1 parent fb49fb8 commit 58704d5

1 file changed

Lines changed: 21 additions & 22 deletions

File tree

  • java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4826,35 +4826,34 @@ void testLocationFastSQLQueryWithJobId() throws InterruptedException {
48264826
/* TODO(prasmish): replicate the entire test case for executeSelect */
48274827
@Test
48284828
void testFastSQLQueryMultiPage() throws InterruptedException {
4829-
String query =
4830-
"SELECT date, county, state_name, county_fips_code, confirmed_cases, deaths FROM "
4831-
+ TABLE_ID_LARGE.getTable();
4829+
String query = "SELECT * FROM UNNEST(GENERATE_ARRAY(1, 1005)) as num";
48324830
QueryJobConfiguration config =
4833-
QueryJobConfiguration.newBuilder(query).setDefaultDataset(DatasetId.of(DATASET)).build();
4831+
QueryJobConfiguration.newBuilder(query)
4832+
.setDefaultDataset(DatasetId.of(DATASET))
4833+
.setMaxResults(1000L)
4834+
.build();
4835+
4836+
java.util.function.Consumer<TableResult> assertResult =
4837+
r -> {
4838+
assertNotNull(r.getJobId());
4839+
assertEquals(1, r.getSchema().getFields().size());
4840+
assertEquals("num", r.getSchema().getFields().get(0).getName());
4841+
assertEquals(LegacySQLTypeName.INTEGER, r.getSchema().getFields().get(0).getType());
4842+
assertEquals(1005, r.getTotalRows());
4843+
assertNotNull(r.getNextPage());
4844+
assertNotNull(r.getNextPageToken());
4845+
assertTrue(r.hasNextPage());
4846+
};
4847+
48344848
TableResult result = bigquery.query(config);
4835-
assertNotNull(result.getJobId());
4836-
assertEquals(LARGE_TABLE_SCHEMA, result.getSchema());
4837-
assertEquals(313348, result.getTotalRows());
4838-
assertNotNull(result.getNextPage());
4839-
assertNotNull(result.getNextPageToken());
4840-
assertTrue(result.hasNextPage());
4849+
assertResult.accept(result);
48414850

48424851
TableResult result1 = bigquery.query(config);
4843-
assertNotNull(result1.getJobId());
4844-
assertEquals(LARGE_TABLE_SCHEMA, result.getSchema());
4845-
assertEquals(313348, result.getTotalRows());
4846-
assertNotNull(result1.getNextPage());
4847-
assertNotNull(result1.getNextPageToken());
4848-
assertTrue(result1.hasNextPage());
4852+
assertResult.accept(result1);
48494853

48504854
config.toBuilder().setQuery(query).build();
48514855
TableResult result2 = bigquery.query(config);
4852-
assertNotNull(result2.getJobId());
4853-
assertEquals(LARGE_TABLE_SCHEMA, result2.getSchema());
4854-
assertEquals(313348, result2.getTotalRows());
4855-
assertNotNull(result2.getNextPage());
4856-
assertNotNull(result2.getNextPageToken());
4857-
assertTrue(result2.hasNextPage());
4856+
assertResult.accept(result2);
48584857
}
48594858

48604859
@Test

0 commit comments

Comments
 (0)