Merge branch 'main' into fix-testbench-and-disable-flaky-tests

Author: Dhriti07

.github/ISSUE_TEMPLATE/bug_report.md

@@ -6,46 +6,119 @@ about: Create a report to help us improve
 
 Thanks for stopping by to let us know something could be better!
 
-**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response.
+**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response. We try to review GitHub issues on a regular basis, however we cannot guarantee an SLO.
 
-Please run down the following list and make sure you've tried the usual "quick fixes":
+Before creating this issue, please run down the following list and make sure you've tried the usual "quick fixes":
 
   - Search the issues already opened: https://github.com/googleapis/google-cloud-java/issues
   - Check for answers on StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform
+  - Refer to the [Google Cloud Java Getting Started guides](https://docs.cloud.google.com/java/getting-started) for common usage patterns and troubleshooting.
+  - Verify you are using the latest versions of the Java SDK. If not, is it possible to upgrade? We recommend using the [Libraries-Bom](https://cloud.google.com/java/docs/bom) to manage dependency versions.
 
-If you are still having issues, please include as much information as possible:
+To help expedite the resolution of the issue, please fill out as much information as possible. If unable to provide information, please note down why the information is unable to be provided.
 
-#### Environment details
+## Issue Details
 
-1. Specify the API at the beginning of the title. For example, "[vision]: ...").
-   General, Core, and Other are also allowed as types
-2. OS type and version:
-3. Java version:
-4. Version(s):
+Required: Provide a detailed description of the issue. Any additional information helps with figuring out the issue.
 
-#### Steps to reproduce
+### Example
+I am seeing {ISSUE} when running X, Y... after doing Z. This behavior started after the X library upgrade a few weeks ago ...
 
-  1. ?
-  2. ?
+## Environment
 
-#### Code example
+Required: Provide details about your environment. If relevant, please also provide details about your GCP environment. The environment details MUST be filled out.
 
-```java
-// example
+Provide the relevant details about your environment:
+
+  - OS Type and Version:
+  - Java Version and JDK Vendor:
+  - (If using GraalVM) GraalVM Version:
+
+(Optional) If deployed on GCP, provide the relevant details about your GCP deployment environment:
+
+  - Project ID:
+  - Cloud Services:
+  - Deployment Environment (Compute, GKE, Run, etc):
+
+## Dependencies
+
+Required: Provide a list of the dependencies that are being used. If unable to provide the list, please list the relevant libraries shown below. One of the two sections below MUST be filled out.
+
+1. List your application’s dependency versions. Please provide the output of `mvn dependency:tree`, `gradle dependencies`, or your build system.
+
+### Example `mvn dependency:tree` output
 ```
+maven-dependency-plugin:tree
+
+- com.google.cloud:{X}:{Y}
+
+- com.google.auth:{X}:{Y}
+
+...
+```
+
+2. Provide the versions of the relevant libraries:
+    - Libraries-Bom ([com.google.cloud:libraries-bom](https://central.sonatype.com/artifact/com.google.cloud/libraries-bom)):
+      - (If not using Libraries-Bom) Client Libraries:
+    - Gax (gax / gax-grpc / gax-httpjson):
+    - Auth (google-auth-library-oauth2-http / google-auth-library-credentials):
+    - Any other relevant Java SDK dependencies:
+      - Google-Http-Java-Client ([com.google.http-client:google-http-client](https://central.sonatype.com/artifact/com.google.http-client/google-http-client)):
+
+## Reproducer
+
+Required: Provide a reproducer and the steps needed to reproduce this issue locally. If unable to provide a reproducer, please provide code snippets to help reproduce the issue. One of the two sections below MUST be filled out.
 
-#### Stack trace
+1. A reproducer is the quickest method to resolve this issue. It could be a test case or a sample application. It is easier for us to troubleshoot the problem and to verify the solution.
+
+Steps to reproduce:
+
+### Example
+1. Enable Speech API
+2. Upload a .mp4 file to GCS
+3. ...
+4. See {ERROR}
+
+If unable to provide a reproducer, please provide a reason: ...
+
+2. Provide as many code snippets as possible:
+
+### Example
+```java
+try (InstancesClient instancesClient = InstancesClient.create()) {
+  ...
+}
 ```
-Any relevant stacktrace here.
+
+## Logs and Stack Trace
+
+Required: Provide logs that showcase the error. This will help show the flow of the application and help narrow down the cause. Additionally, provide a stack trace of the error if possible.
+
+The Java SDK has a troubleshooting [guide](https://github.com/googleapis/google-cloud-java/blob/main/TROUBLESHOOTING.md) for enabling logs. This contains information regarding client-server communication, request and response details, and logging in dependency libraries. If using this guide, please obfuscate any private information (bearer tokens, request and response params, etc).
+
+Additionally, please provide a stack trace of the error seen:
+
+### Example
 ```
+TransportContext.java:347|Fatal (CERTIFICATE_UNKNOWN): PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target (
+
+"throwable" : {
 
-#### External references such as API reference guides
+sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
 
-- ?
+	at sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:456)
+
+	at sun.security.validator.PKIXValidator.engineValidate(PKIXValidator.java:323)
+
+...
+```
 
-#### Any additional information below
+## Behavior
 
+Optional: Any additional information about the behavior of the error is helpful to debug.
 
-Following these steps guarantees the quickest resolution possible.
+Behavioral Questions:
 
-Thanks!
+  - When did the issue begin? Is this behavior related to any dependency version upgrade?
+  - Is this behavior flaky? Or is this consistently seen in production?
+  - Is this behavior related to the volume of data?

.github/workflows/generated_files_sync.yaml

@@ -17,7 +17,7 @@ on:
   pull_request:
 name: generation diff
 env:
-  library_generation_image_tag: 2.73.0-SNAPSHOT  # {x-version-update:gapic-generator-java:current}
+  library_generation_image_tag: 2.73.0  # {x-version-update:gapic-generator-java:current}
 jobs:
   root-pom:
     # root pom.xml does not have diff from generated one

.github/workflows/hermetic_library_generation.yaml

@@ -21,7 +21,7 @@ env:
   REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }}
   GITHUB_REPOSITORY: ${{ github.repository }}
   # {x-version-update-start:gapic-generator-java:current}
-  GENERATOR_VERSION: 2.73.0-SNAPSHOT
+  GENERATOR_VERSION: 2.73.0
   # {x-version-update-end}
 jobs:
   library_generation:

.github/workflows/update_librarian_googleapis.yaml

@@ -68,8 +68,8 @@ jobs:
         new_commit=$(go run "github.com/googleapis/librarian/cmd/librarian@${version}" config get sources.googleapis.commit)
         echo "new_commit=${new_commit}" >> $GITHUB_OUTPUT
         echo "short_commit=${new_commit:0:7}" >> $GITHUB_OUTPUT
-    - name: Detect Changes
-      id: detect
+    - name: Detect Changes To Librarian.yaml
+      id: detect_librarian
       run: |
         git add librarian.yaml
         changed_files=$(git diff --cached --name-only)
@@ -79,8 +79,51 @@ jobs:
         else
           echo "has_changes=true" >> $GITHUB_OUTPUT
         fi
+    - name: Install protoc
+      run: |
+        set -e
+        VERSION="33.2"
+        curl -fsSL --retry 5 --retry-delay 15 -o /tmp/protoc.zip "https://github.com/protocolbuffers/protobuf/releases/download/v$VERSION/protoc-$VERSION-linux-x86_64.zip"
+        cd /usr/local
+        sudo unzip -o /tmp/protoc.zip
+        protoc --version
+    - uses: actions/setup-java@v4
+      with:
+        java-version: "17"
+        distribution: "temurin"
+        cache: "maven"
+    - name: Verify Java and Maven installation
+      run: |
+        java -version
+        if ! command -v mvn &> /dev/null; then
+          sudo apt-get update && sudo apt-get install -y maven
+        fi
+        mvn -version
+    - uses: actions/setup-python@v5
+      with:
+        python-version: "3.12"
+        cache: 'pip'
+    - name: Run librarian install
+      run: |
+        go run github.com/googleapis/librarian/cmd/librarian@latest install
+        echo "$HOME/java_tools/bin" >> $GITHUB_PATH
+      env:
+        PYTHONPATH: ${{ github.workspace }}/sdk-platform-java/hermetic_build/library_generation/owlbot
+    - name: Generate Libraries
+      if: steps.detect_librarian.outputs.has_changes == 'true'
+      id: generate
+      run: |
+        go run github.com/googleapis/librarian/cmd/librarian@latest generate --all
+        git add .
+        changed_files=$(git diff --cached --name-only)
+        if [[ "${changed_files}" == "" ]]; then
+          echo "has_changes=false" >> $GITHUB_OUTPUT
+          echo "No changes in libraries"
+        else
+          echo "has_changes=true" >> $GITHUB_OUTPUT
+        fi
     - name: Commit and Create PR
-      if: steps.detect.outputs.has_changes == 'true'
+      if: steps.detect_librarian.outputs.has_changes == 'true' || steps.generate.outputs.has_changes == 'true'
       env:
         GH_TOKEN: ${{ secrets.CLOUD_JAVA_BOT_GITHUB_TOKEN }}
         PR_TITLE: "chore: update googleapis commitish to ${{ steps.commit.outputs.short_commit }}"

.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "1.86.0"
+  ".": "1.87.0"
 }