Skip to content

Commit 68713ce

Browse files
committed
fix(bigquery-jdbc): prevent file descriptor leak when reading external credentials
1 parent f0d82a6 commit 68713ce

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcOAuthUtility.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -664,10 +664,11 @@ private static GoogleCredentials getExternalAccountAuthCredentials(
664664

665665
ExternalAccountCredentials credentials;
666666
if (credentialsPath != null) {
667-
credentials =
668-
(ExternalAccountCredentials)
669-
ExternalAccountCredentials.fromStream(
670-
Files.newInputStream(Paths.get(credentialsPath)), httpTransportFactory);
667+
try (InputStream stream = Files.newInputStream(Paths.get(credentialsPath))) {
668+
credentials =
669+
(ExternalAccountCredentials)
670+
ExternalAccountCredentials.fromStream(stream, httpTransportFactory);
671+
}
671672
} else if (jsonObject != null) {
672673
credentials =
673674
(ExternalAccountCredentials)

0 commit comments

Comments
 (0)