add regular type tests

Author: Neenu1995

java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryArrowResultSetTest.java

@@ -29,20 +29,27 @@
 import com.google.cloud.bigquery.FieldList;
 import com.google.cloud.bigquery.Schema;
 import com.google.cloud.bigquery.StandardSQLTypeName;
+import com.google.cloud.bigquery.jdbc.rules.TimeZoneRule;
+import org.junit.jupiter.api.extension.RegisterExtension;
 import com.google.cloud.bigquery.storage.v1.ArrowRecordBatch;
 import com.google.cloud.bigquery.storage.v1.ArrowSchema;
 import com.google.common.collect.ImmutableList;
 import java.io.IOException;
 import java.math.BigDecimal;
 import java.sql.Array;
+import java.sql.Date;
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.Struct;
+import java.sql.Time;
+import java.sql.Timestamp;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.time.LocalTime;
 import java.util.Arrays;
+import java.util.Calendar;
 import java.util.List;
+import java.util.TimeZone;
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.LinkedBlockingDeque;
 import java.util.stream.Stream;
@@ -71,6 +78,13 @@
 
 public class BigQueryArrowResultSetTest {
 
+  static {
+    TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
+    TimeZoneCache.reset();
+  }
+
+  @RegisterExtension public static final TimeZoneRule timeZoneRule = new TimeZoneRule("UTC");
+
   private static final FieldList fieldList =
       FieldList.of(
           Field.of("boolField", StandardSQLTypeName.BOOL),
@@ -374,7 +388,13 @@ public static Stream<Arguments> successfulCoercionCases() {
         Arguments.of("float64Field", Double.class, 1.1),
         Arguments.of("stringField", String.class, "text1"),
         Arguments.of("numericField", BigDecimal.class, BigDecimal.ONE),
-        Arguments.of(9, Long.class, 1L));
+        Arguments.of(9, Long.class, 1L),
+        Arguments.of("timeField", Time.class, new Time(1234L)),
+        Arguments.of(10, Time.class, new Time(1234L)),
+        Arguments.of("timeStampField", Timestamp.class, new Timestamp(10L)),
+        Arguments.of(5, Timestamp.class, new Timestamp(10L)),
+        Arguments.of("dateField", Date.class, new Date(0L)),
+        Arguments.of(11, Date.class, new Date(0L)));
   }
 
   public static Stream<Arguments> failingCoercionCases() {
@@ -409,6 +429,7 @@ public void testGetObjectWithType_failure(Object column, Class<?> type) throws S
     }
   }
 
+
   private int resultSetRowCount(BigQueryArrowResultSet resultSet) throws SQLException {
     int rowCount = 0;
     while (resultSet.next()) {

java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryJsonResultSetTest.java

@@ -66,7 +66,12 @@
 
 public class BigQueryJsonResultSetTest {
 
-  @RegisterExtension public final TimeZoneRule timeZoneRule = new TimeZoneRule("UTC");
+  static {
+    TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
+    TimeZoneCache.reset();
+  }
+
+  @RegisterExtension public static final TimeZoneRule timeZoneRule = new TimeZoneRule("UTC");
 
   private static final FieldList fieldList =
       FieldList.of(
@@ -436,41 +441,6 @@ public void testIterationNested() throws SQLException {
     assertThat(bigQueryJsonResultSetNested.isAfterLast()).isTrue();
   }
 
-  @Test
-  public void testTime() throws SQLException {
-    assertThat(resetResultSet()).isTrue();
-    Calendar calendar = Calendar.getInstance(TimeZone.getTimeZone("EST"));
-    Time expectedTime = new Time(TimeUnit.NANOSECONDS.toMillis(aTime.toNanoOfDay()));
-    assertThat(bigQueryJsonResultSet.getTime(12))
-        .isEqualTo(bigQueryJsonResultSet.getTime(12, calendar));
-    assertThat(expectedTime).isEqualTo(bigQueryJsonResultSet.getTime(12, calendar));
-    assertThat(bigQueryJsonResultSet.getTime("twelfth"))
-        .isEqualTo(bigQueryJsonResultSet.getTime("twelfth", calendar));
-  }
-
-  @Test
-  public void testTimestamp() throws SQLException {
-    assertThat(resetResultSet()).isTrue();
-    Calendar calendar = Calendar.getInstance(TimeZone.getTimeZone("EST"));
-    Timestamp time = bigQueryJsonResultSet.getTimestamp(5);
-    Timestamp timeWithCal = bigQueryJsonResultSet.getTimestamp(5, calendar);
-    assertThat(time).isEqualTo(timeWithCal);
-    assertThat(bigQueryJsonResultSet.getTimestamp("fifth"))
-        .isEqualTo(bigQueryJsonResultSet.getTimestamp("fifth"));
-  }
-
-  @Test
-  public void testDate() throws SQLException {
-    assertThat(resetResultSet()).isTrue();
-    Calendar calendar = Calendar.getInstance(TimeZone.getTimeZone("EST"));
-    // epoc should match
-    assertThat(bigQueryJsonResultSet.getDate(14).getTime())
-        .isEqualTo(bigQueryJsonResultSet.getDate(14, calendar).getTime());
-    assertThat(Date.valueOf("2020-01-15").getTime())
-        .isEqualTo(bigQueryJsonResultSet.getDate(14, calendar).getTime());
-    assertThat(bigQueryJsonResultSet.getDate("fourteenth").getTime())
-        .isEqualTo(bigQueryJsonResultSet.getDate("fourteenth", calendar).getTime());
-  }
 
   public static Stream<Arguments> successfulCoercionCases() {
     return Stream.of(
@@ -493,7 +463,13 @@ public static Stream<Arguments> successfulCoercionCases() {
         Arguments.of("tenth", BigDecimal.class, new BigDecimal("12345678")),
         Arguments.of(10, Long.class, 12345678L),
         Arguments.of("eleventh", BigDecimal.class, new BigDecimal("12345678.99")),
-        Arguments.of(11, Double.class, 12345678.99D));
+        Arguments.of(11, Double.class, 12345678.99D),
+        Arguments.of("twelfth", Time.class, new Time(40459820L)),
+        Arguments.of(12, Time.class, new Time(40459820L)),
+        Arguments.of("fifth", Timestamp.class, new Timestamp(1680174859820L)),
+        Arguments.of(5, Timestamp.class, new Timestamp(1680174859820L)),
+        Arguments.of("fourteenth", Date.class, Date.valueOf("2020-01-15")),
+        Arguments.of(14, Date.class, Date.valueOf("2020-01-15")));
   }
 
   public static Stream<Arguments> failingCoercionCases() {