Commit 7b5efb5
authored
fix(java-firestore): preserve FirestoreAdminVersion.java during regeneration (#13415)
This is a followup fix for
#13397.
Fix an issue in java-firestore/owlbot.py in locating
"google-cloud-firestore-admin" that prevented the replacement logic
taking effect in FirestoreAdminStubSettings.java.
Remove the custom `Version.java` to `FirestoreAdminVersion.java`
renaming logic from owlbot.py. Instead, rely on excluding `Version.java`
during the directory move (s.move) to discard the generated version
file. `FirestoreAdminVersion.java` is added to the `keep` list in
`librarian.yaml` to preserve.
Tested regeneration locally with `go run
github.com/googleapis/librarian/cmd/librarian@${V} generate firestore`1 parent fb49fb8 commit 7b5efb5
4 files changed
Lines changed: 20 additions & 47 deletions
File tree
- java-firestore
- google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/stub
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
757 | 757 | | |
758 | 758 | | |
759 | 759 | | |
760 | | - | |
| 760 | + | |
761 | 761 | | |
762 | 762 | | |
763 | 763 | | |
| |||
Lines changed: 0 additions & 27 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
63 | 62 | | |
64 | 63 | | |
65 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1755 | 1755 | | |
1756 | 1756 | | |
1757 | 1757 | | |
| 1758 | + | |
1758 | 1759 | | |
1759 | 1760 | | |
1760 | 1761 | | |
| |||
0 commit comments