Skip to content

Commit 7e5f23b

Browse files
committed
IgnoreNonCompile to reduce the test dependency exclusions
1 parent dbfc2ce commit 7e5f23b

9 files changed

Lines changed: 4 additions & 25 deletions

File tree

google-cloud-jar-parent/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
</parent>
2121
<properties>
2222
<skipUnitTests>false</skipUnitTests>
23+
<ignoreNonCompile>true</ignoreNonCompile><!-- maven-dependency-plugin:analyze to skip test scope dependencies -->
2324
</properties>
2425

2526
<dependencyManagement>

sdk-platform-java/gapic-generator-java-pom-parent/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
<slf4j.version>2.0.16</slf4j.version>
4141
<!-- skipping clirr check for protobuf 4.x upgrade -->
4242
<clirr.skip>true</clirr.skip>
43+
<ignoreNonCompile>true</ignoreNonCompile><!-- maven-dependency-plugin:analyze to skip test scope dependencies -->
4344
</properties>
4445

4546
<developers>

sdk-platform-java/gapic-generator-java/pom.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,6 @@
379379
<configuration>
380380
<ignoredUnusedDeclaredDependencies>
381381
<ignoredUnusedDeclaredDependency>com.google.errorprone:error_prone_annotations</ignoredUnusedDeclaredDependency>
382-
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependency>
383382
</ignoredUnusedDeclaredDependencies>
384383
</configuration>
385384
</plugin>
@@ -505,7 +504,7 @@
505504
<dependency>
506505
<groupId>com.google.api</groupId>
507506
<artifactId>api-common</artifactId>
508-
<version>2.62.0</version>
507+
<version>2.62.0</version><!-- {x-version-update:api-common:current} -->
509508
</dependency>
510509
<dependency>
511510
<groupId>org.junit.jupiter</groupId>
@@ -531,7 +530,7 @@
531530
<dependency>
532531
<groupId>com.google.api.grpc</groupId>
533532
<artifactId>proto-google-common-protos</artifactId>
534-
<version>2.70.0</version>
533+
<version>2.70.0</version><!-- {x-version-update:proto-google-common-protos:current} -->
535534
</dependency>
536535
<dependency>
537536
<groupId>com.google.protobuf</groupId>

sdk-platform-java/gax-java/gax-grpc/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,6 @@
171171
<ignoredUnusedDeclaredDependency>io.grpc:grpc-googleapis</ignoredUnusedDeclaredDependency>
172172
<ignoredUnusedDeclaredDependency>org.slf4j:slf4j-api</ignoredUnusedDeclaredDependency>
173173
<ignoredUnusedDeclaredDependency>io.grpc:grpc-s2a</ignoredUnusedDeclaredDependency>
174-
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependency>
175-
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-params</ignoredUnusedDeclaredDependency>
176174
</ignoredUnusedDeclaredDependencies>
177175
</configuration>
178176
</plugin>

sdk-platform-java/gax-java/gax-httpjson/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,6 @@
132132
<configuration>
133133
<ignoredUnusedDeclaredDependencies>
134134
<ignoredUnusedDeclaredDependency>org.slf4j:slf4j-api</ignoredUnusedDeclaredDependency>
135-
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependency>
136-
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-params</ignoredUnusedDeclaredDependency>
137135
</ignoredUnusedDeclaredDependencies>
138136
</configuration>
139137
</plugin>

sdk-platform-java/gax-java/gax/pom.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -179,15 +179,6 @@
179179
</excludes>
180180
</configuration>
181181
</plugin>
182-
<plugin>
183-
<groupId>org.apache.maven.plugins</groupId>
184-
<artifactId>maven-dependency-plugin</artifactId>
185-
<configuration>
186-
<ignoredUnusedDeclaredDependencies>
187-
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependency>
188-
</ignoredUnusedDeclaredDependencies>
189-
</configuration>
190-
</plugin>
191182
<plugin>
192183
<!-- Troubleshooting a flaky test in https://github.com/googleapis/sdk-platform-java/issues/1931 -->
193184
<groupId>org.apache.maven.plugins</groupId>

sdk-platform-java/java-core/google-cloud-core-grpc/pom.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,6 @@
9090
<configuration>
9191
<ignoredUnusedDeclaredDependencies>
9292
<ignoredUnusedDeclaredDependency>com.google.errorprone:error_prone_annotations</ignoredUnusedDeclaredDependency>
93-
<ignoredUnusedDeclaredDependency>org.junit.platform:junit-platform-launcher</ignoredUnusedDeclaredDependency>
94-
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependency>
95-
<ignoredUnusedDeclaredDependency>org.junit.vintage:junit-vintage-engine</ignoredUnusedDeclaredDependency>
9693
</ignoredUnusedDeclaredDependencies>
9794
</configuration>
9895
</plugin>

sdk-platform-java/java-core/google-cloud-core-http/pom.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,6 @@
116116
<configuration>
117117
<ignoredUnusedDeclaredDependencies>
118118
<ignoredUnusedDeclaredDependency>com.google.errorprone:error_prone_annotations</ignoredUnusedDeclaredDependency>
119-
<ignoredUnusedDeclaredDependency>org.junit.platform:junit-platform-launcher</ignoredUnusedDeclaredDependency>
120-
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependency>
121-
<ignoredUnusedDeclaredDependency>org.junit.vintage:junit-vintage-engine</ignoredUnusedDeclaredDependency>
122119
</ignoredUnusedDeclaredDependencies>
123120
</configuration>
124121
</plugin>

sdk-platform-java/java-core/google-cloud-core/pom.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,6 @@
130130
<configuration>
131131
<ignoredUnusedDeclaredDependencies>
132132
<ignoredUnusedDeclaredDependency>com.google.errorprone:error_prone_annotations</ignoredUnusedDeclaredDependency>
133-
<ignoredUnusedDeclaredDependency>org.junit.platform:junit-platform-launcher</ignoredUnusedDeclaredDependency>
134-
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependency>
135-
<ignoredUnusedDeclaredDependency>org.junit.vintage:junit-vintage-engine</ignoredUnusedDeclaredDependency>
136133
</ignoredUnusedDeclaredDependencies>
137134
</configuration>
138135
</plugin>

0 commit comments

Comments
 (0)