Skip to content

Commit 8426daf

Browse files
authored
Merge branch 'main' into fix-logging-tracer-exception-details
2 parents 0148485 + 914f97f commit 8426daf

File tree

5 files changed

+21
-18
lines changed

5 files changed

+21
-18
lines changed

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4698,13 +4698,10 @@ void testProjectIDFastSQLQueryWithJobId() {
46984698
JobId jobIdWithProjectId = JobId.newBuilder().setProject(invalidProjectId).build();
46994699
QueryJobConfiguration configSelect =
47004700
QueryJobConfiguration.newBuilder(query).setDefaultDataset(DatasetId.of(DATASET)).build();
4701-
try {
4702-
bigquery.query(configSelect, jobIdWithProjectId);
4703-
} catch (Exception exception) {
4704-
// error message for non-existent project
4705-
assertEquals("Cannot parse as CloudRegion.", exception.getMessage());
4706-
assertEquals(BigQueryException.class, exception.getClass());
4707-
}
4701+
BigQueryException bqException =
4702+
assertThrows(
4703+
BigQueryException.class, () -> bigquery.query(configSelect, jobIdWithProjectId));
4704+
assertEquals(400, bqException.getCode());
47084705
}
47094706

47104707
@Test

java-storage/google-cloud-storage-control/pom.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
<dependency>
5454
<groupId>com.google.api</groupId>
5555
<artifactId>gax</artifactId>
56-
<version>2.76.1-SNAPSHOT</version><!-- {x-version-update:gax:current} -->
5756
</dependency>
5857
<dependency>
5958
<groupId>com.google.api</groupId>
@@ -71,14 +70,14 @@
7170
<dependency>
7271
<groupId>com.google.api</groupId>
7372
<artifactId>gax-httpjson</artifactId>
74-
<version>2.76.1-SNAPSHOT</version><!-- {x-version-update:gax-httpjson:current} -->
73+
<version>2.76.1-SNAPSHOT</version><!-- {x-version-update:gax:current} -->
7574
</dependency>
7675
<dependency>
7776
<groupId>com.google.api</groupId>
7877
<artifactId>gax-httpjson</artifactId>
7978
<scope>test</scope>
8079
<classifier>testlib</classifier>
81-
<version>2.76.1-SNAPSHOT</version><!-- {x-version-update:gax-httpjson:current} -->
80+
<version>2.76.1-SNAPSHOT</version><!-- {x-version-update:gax:current} -->
8281
</dependency>
8382
<dependency>
8483
<groupId>com.google.guava</groupId>

sdk-platform-java/GEMINI.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,22 @@ Showcase integration tests are run against a local server that implements the Sh
131131
cd java-showcase
132132
mvn verify -P enable-integration-tests
133133
```
134-
135-
## 5. Dependency Management
134+
135+
## 5. Style Guide
136+
137+
1. Minimize visibility scopes by defaulting to the most restrictive access level, avoiding the `public` modifier unless required.
138+
2. Use short names over fully qualified names.
139+
3. Avoid calling `@ObsoleteApi` or `@Deprecated` methods unless there are no alternatives.
140+
4. Avoid unnecessary formatting changes to keep diffs clean.
141+
5. Use `mvn` for everything other than the `test/integration` folder.
142+
143+
## 6. Dependency Management
136144

137145
- Try not to bump any external dependency version unless there is a known CVE (security or vulnerability issue) or a critical bug fix.
138146
- Try to avoid introducing new external dependencies. If a new dependency is required, please state the reason.
139147
- Prefer to use features from the Java standard library, then try to use features from any existing dependencies (preferably from Google managed dependencies).
140148

141-
## 6. Contribution Guidelines
149+
## 7. Contribution Guidelines
142150

143151
- **Commits:** Commit messages should follow the [Conventional Commits](https://www.conventionalcommits.org/)
144152
specification. The format is `<type>: <description>`. The type should be one of the following: fix, feat,

sdk-platform-java/dependencies.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
# Pom-Parent Dependencies
1010
# These dependencies are declared: https://github.com/googleapis/sdk-platform-java/blob/main/gapic-generator-java-pom-parent/pom.xml
1111
javax.annotation:javax.annotation-api,javax.annotation-api=1.3.2
12-
io.grpc:grpc-bom,grpc=1.79.0
12+
io.grpc:grpc-bom,grpc=1.80.0
1313
com.google.auth:google-auth-library-bom,google.auth=1.43.0
1414
com.google.http-client:google-http-client,google.http-client=2.1.0
1515
com.google.code.gson:gson,gson=2.13.2
1616
com.google.guava:guava,guava=33.5.0-jre
17-
com.google.protobuf:protobuf-java,protobuf=4.34.0
17+
com.google.protobuf:protobuf-java,protobuf=4.34.1
1818
io.opentelemetry:opentelemetry-bom,opentelemetry=1.60.1
1919
com.google.errorprone:error_prone_annotations,errorprone=2.48.0
2020
com.google.j2objc:j2objc-annotations,j2objc-annotations=3.1
@@ -32,7 +32,7 @@ com.google.api-client:google-api-client,google.api-client=2.9.0
3232
org.threeten:threeten-extra,threeten-extra=1.8.0
3333
io.opencensus:opencensus-api,opencensus=0.31.1
3434
com.google.code.findbugs:jsr305,findbugs=3.0.2
35-
com.fasterxml.jackson:jackson-bom,jackson=2.21.1
35+
com.fasterxml.jackson:jackson-bom,jackson=2.21.2
3636
commons-codec:commons-codec,codec=1.21.0
3737
org.apache.httpcomponents:httpclient,httpcomponents.httpclient=4.5.14
3838
org.apache.httpcomponents:httpcore,httpcomponents.httpcore=4.4.16
@@ -45,7 +45,7 @@ com.google.cloud.opentelemetry:exporter-metrics,google.cloud.opentelemetry=0.36.
4545
com.google.flogger:flogger,flogger=0.9
4646
org.apache.arrow:arrow-memory-core,arrow=18.3.0
4747
dev.cel:cel,dev.cel=0.12.0
48-
com.google.crypto.tink:tink,com.google.crypto.tink=1.20.0
48+
com.google.crypto.tink:tink,com.google.crypto.tink=1.21.0
4949
# The follow opentelemetry dependencies have a different version from the opentelemetry-bom
5050
io.opentelemetry.semconv:opentelemetry-semconv,opentelemetry-semconv=1.40.0
5151
io.opentelemetry.contrib:opentelemetry-gcp-resources,io.opentelemetry.contrib.opentelemetry-gcp-resources=1.52.0-alpha

versions.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -986,7 +986,6 @@ gapic-generator-java:2.68.0:2.68.1-SNAPSHOT
986986
api-common:2.59.0:2.59.1-SNAPSHOT
987987
gax:2.76.0:2.76.1-SNAPSHOT
988988
gax-grpc:2.76.0:2.76.1-SNAPSHOT
989-
gax-httpjson:0.161.0:0.161.1-SNAPSHOT
990989
proto-google-common-protos:2.67.0:2.67.1-SNAPSHOT
991990
grpc-google-common-protos:2.67.0:2.67.1-SNAPSHOT
992991
proto-google-iam-v1:1.62.0:1.62.1-SNAPSHOT

0 commit comments

Comments
 (0)