refactor: use ObservabilityUtils.extractErrorInfo helper

Author: westarle

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/LoggingTracer.java

@@ -34,7 +34,6 @@
 import com.google.api.core.InternalApi;
 import com.google.api.gax.logging.LoggerProvider;
 import com.google.api.gax.logging.LoggingUtils;
-import com.google.api.gax.rpc.ApiException;
 import com.google.rpc.ErrorInfo;
 import java.util.HashMap;
 import java.util.Map;
@@ -104,17 +103,12 @@ private void recordActionableError(Throwable error) {
           ObservabilityUtils.extractStatus(error));
     }
 
-    if (error instanceof ApiException) {
-      ApiException apiException = (ApiException) error;
-      if (apiException.getErrorDetails() != null) {
-        ErrorInfo errorInfo = apiException.getErrorDetails().getErrorInfo();
-        if (errorInfo != null) {
-          logContext.put("error.type", errorInfo.getReason());
-          logContext.put("gcp.errors.domain", errorInfo.getDomain());
-          for (Map.Entry<String, String> entry : errorInfo.getMetadataMap().entrySet()) {
-            logContext.put("gcp.errors.metadata." + entry.getKey(), entry.getValue());
-          }
-        }
+    ErrorInfo errorInfo = ObservabilityUtils.extractErrorInfo(error);
+    if (errorInfo != null) {
+      logContext.put("error.type", errorInfo.getReason());
+      logContext.put("gcp.errors.domain", errorInfo.getDomain());
+      for (Map.Entry<String, String> entry : errorInfo.getMetadataMap().entrySet()) {
+        logContext.put("gcp.errors.metadata." + entry.getKey(), entry.getValue());
       }
     }
 

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/ObservabilityUtils.java

@@ -31,6 +31,7 @@
 
 import com.google.api.gax.rpc.ApiException;
 import com.google.api.gax.rpc.StatusCode;
+import com.google.rpc.ErrorInfo;
 import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.api.common.AttributesBuilder;
 import java.util.Map;
@@ -56,6 +57,18 @@ static String extractStatus(@Nullable Throwable error) {
     return statusString;
   }
 
+  /** Function to extract the ErrorInfo payload from the error, if available */
+  @Nullable
+  static ErrorInfo extractErrorInfo(@Nullable Throwable error) {
+    if (error instanceof ApiException) {
+      ApiException apiException = (ApiException) error;
+      if (apiException.getErrorDetails() != null) {
+        return apiException.getErrorDetails().getErrorInfo();
+      }
+    }
+    return null;
+  }
+
   static Attributes toOtelAttributes(Map<String, Object> attributes) {
     AttributesBuilder attributesBuilder = Attributes.builder();
     if (attributes == null) {