Skip to content

Commit 86f4b72

Browse files
committed
test(bigquery): use TABLE_ID_LARGE with LIMIT 5000 and maxResults to make testFastSQLQueryMultiPage hermetic and fast
b/467064659
1 parent fb49fb8 commit 86f4b72

1 file changed

Lines changed: 22 additions & 22 deletions

File tree

  • java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4823,38 +4823,38 @@ void testLocationFastSQLQueryWithJobId() throws InterruptedException {
48234823
}
48244824
}
48254825

4826-
/* TODO(prasmish): replicate the entire test case for executeSelect */
48274826
@Test
48284827
void testFastSQLQueryMultiPage() throws InterruptedException {
48294828
String query =
48304829
"SELECT date, county, state_name, county_fips_code, confirmed_cases, deaths FROM "
4831-
+ TABLE_ID_LARGE.getTable();
4830+
+ TABLE_ID_LARGE.getTable()
4831+
+ " LIMIT 5000";
48324832
QueryJobConfiguration config =
4833-
QueryJobConfiguration.newBuilder(query).setDefaultDataset(DatasetId.of(DATASET)).build();
4833+
QueryJobConfiguration.newBuilder(query)
4834+
.setDefaultDataset(DatasetId.of(DATASET))
4835+
.setMaxResults(1000L)
4836+
.build();
4837+
4838+
java.util.function.Consumer<TableResult> assertResult =
4839+
r -> {
4840+
assertNotNull(r.getJobId());
4841+
assertEquals(LARGE_TABLE_SCHEMA, r.getSchema());
4842+
assertEquals(5000, r.getTotalRows());
4843+
assertEquals(1000, com.google.common.collect.Iterables.size(r.getValues()));
4844+
assertNotNull(r.getNextPage());
4845+
assertNotNull(r.getNextPageToken());
4846+
assertTrue(r.hasNextPage());
4847+
};
4848+
48344849
TableResult result = bigquery.query(config);
4835-
assertNotNull(result.getJobId());
4836-
assertEquals(LARGE_TABLE_SCHEMA, result.getSchema());
4837-
assertEquals(313348, result.getTotalRows());
4838-
assertNotNull(result.getNextPage());
4839-
assertNotNull(result.getNextPageToken());
4840-
assertTrue(result.hasNextPage());
4850+
assertResult.accept(result);
48414851

48424852
TableResult result1 = bigquery.query(config);
4843-
assertNotNull(result1.getJobId());
4844-
assertEquals(LARGE_TABLE_SCHEMA, result.getSchema());
4845-
assertEquals(313348, result.getTotalRows());
4846-
assertNotNull(result1.getNextPage());
4847-
assertNotNull(result1.getNextPageToken());
4848-
assertTrue(result1.hasNextPage());
4853+
assertResult.accept(result1);
48494854

4850-
config.toBuilder().setQuery(query).build();
4855+
config = config.toBuilder().setQuery(query).build();
48514856
TableResult result2 = bigquery.query(config);
4852-
assertNotNull(result2.getJobId());
4853-
assertEquals(LARGE_TABLE_SCHEMA, result2.getSchema());
4854-
assertEquals(313348, result2.getTotalRows());
4855-
assertNotNull(result2.getNextPage());
4856-
assertNotNull(result2.getNextPageToken());
4857-
assertTrue(result2.hasNextPage());
4857+
assertResult.accept(result2);
48584858
}
48594859

48604860
@Test

0 commit comments

Comments
 (0)