chore: Add transport as an attribute

Author: lqiu96

java-datastore/google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreImpl.java

@@ -44,6 +44,7 @@
 import com.google.cloud.RetryHelper;
 import com.google.cloud.RetryHelper.RetryHelperException;
 import com.google.cloud.ServiceOptions;
+import com.google.cloud.TransportOptions;
 import com.google.cloud.datastore.execution.AggregationQueryExecutor;
 import com.google.cloud.datastore.spi.v1.DatastoreRpc;
 import com.google.cloud.datastore.telemetry.MetricsRecorder;
@@ -215,7 +216,7 @@ public T call() throws DatastoreException {
         }
         throw DatastoreException.propagateUserException(ex);
       } finally {
-        recordAttempt(attemptStatus);
+        recordAttempt(attemptStatus, datastore.getOptions().getTransportOptions());
         // If the transaction is active, then commit the rollback. If it was already successfully
         // rolled back, the transaction is inactive (prevents rolling back an already rolled back
         // transaction).
@@ -233,7 +234,7 @@ public T call() throws DatastoreException {
      * Records a single transaction commit attempt with the given status code. This is called once
      * per invocation of {@link #call()}, capturing the outcome of each individual commit attempt.
      */
-    private void recordAttempt(String status) {
+    private void recordAttempt(String status, TransportOptions transportOptions) {
       Map<String, String> attributes = new HashMap<>();
       attributes.put(TelemetryConstants.ATTRIBUTES_KEY_STATUS, status);
       attributes.put(
@@ -242,6 +243,9 @@ private void recordAttempt(String status) {
           TelemetryConstants.ATTRIBUTES_KEY_PROJECT_ID, datastore.getOptions().getProjectId());
       attributes.put(
           TelemetryConstants.ATTRIBUTES_KEY_DATABASE_ID, datastore.getOptions().getDatabaseId());
+      attributes.put(
+          TelemetryConstants.ATTRIBUTES_KEY_TRANSPORT,
+          TelemetryConstants.getTransportName(transportOptions));
       metricsRecorder.recordTransactionAttemptCount(1, attributes);
     }
   }
@@ -284,6 +288,9 @@ public <T> T runInTransaction(
           TelemetryConstants.ATTRIBUTES_KEY_METHOD, TelemetryConstants.METHOD_TRANSACTION_RUN);
       attributes.put(TelemetryConstants.ATTRIBUTES_KEY_PROJECT_ID, getOptions().getProjectId());
       attributes.put(TelemetryConstants.ATTRIBUTES_KEY_DATABASE_ID, getOptions().getDatabaseId());
+      attributes.put(
+          TelemetryConstants.ATTRIBUTES_KEY_TRANSPORT,
+          TelemetryConstants.getTransportName(getOptions().getTransportOptions()));
       metricsRecorder.recordTransactionLatency(latencyMs, attributes);
       span.end();
     }

java-datastore/google-cloud-datastore/src/main/java/com/google/cloud/datastore/telemetry/TelemetryConstants.java

@@ -17,6 +17,8 @@
 package com.google.cloud.datastore.telemetry;
 
 import com.google.api.core.InternalApi;
+import com.google.cloud.TransportOptions;
+import com.google.cloud.grpc.GrpcTransportOptions;
 
 /**
  * Internal telemetry constants shared between OpenTelemetry tracing and metrics.
@@ -51,13 +53,17 @@ public class TelemetryConstants {
   /** Attribute key for the Datastore database ID. */
   public static final String ATTRIBUTES_KEY_DATABASE_ID = "database_id";
 
+  public static final String ATTRIBUTES_KEY_LIBRARY_VERSION = "library_version";
+
+  public static final String ATTRIBUTES_KEY_TRANSPORT = "transport";
+
   /** Metric name for the total latency of a transaction. */
   public static final String METRIC_NAME_TRANSACTION_LATENCY =
-      SERVICE_NAME + "/transaction_latency";
+      SERVICE_NAME + "/client/transaction_latency";
 
   /** Metric name for the number of attempts a transaction took. */
   public static final String METRIC_NAME_TRANSACTION_ATTEMPT_COUNT =
-      SERVICE_NAME + "/transaction_attempt_count";
+      SERVICE_NAME + "/client/transaction_attempt_count";
 
   /* TODO(lawrenceqiu): For now, these are a duplicate of method names in TraceUtil. Those will use these eventually */
   // Format is not SnakeCase to keep backward compatibility with the existing values TraceUtil spans
@@ -81,4 +87,12 @@ public class TelemetryConstants {
   public static final String METHOD_SUBMIT = "submit";
 
   private TelemetryConstants() {}
+
+  public static String getTransportName(TransportOptions transportOptions) {
+    if (transportOptions instanceof GrpcTransportOptions) {
+      return "grpc";
+    } else {
+      return "http";
+    }
+  }
 }