Skip to content

Commit 914dc9f

Browse files
committed
make ErrorTypeUtil package private so we can remove without it being a breaking change.
1 parent 0e0fc1d commit 914dc9f

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/telemetry/ErrorTypeUtil.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,9 @@
2222
* replaced with gax version when ready work tracked in
2323
* https://github.com/googleapis/google-cloud-java/issues/12105
2424
*/
25-
@VisibleForTesting
26-
public class ErrorTypeUtil {
25+
class ErrorTypeUtil {
2726

28-
@VisibleForTesting
29-
public enum ErrorType {
27+
enum ErrorType {
3028
CLIENT_TIMEOUT,
3129
CLIENT_CONNECTION_ERROR,
3230
CLIENT_REQUEST_ERROR,

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITOpenTelemetryTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
*/
1616
package com.google.cloud.bigquery.it;
1717

18-
import static com.google.cloud.bigquery.telemetry.ErrorTypeUtil.ErrorType;
1918
import static org.junit.jupiter.api.Assertions.assertEquals;
2019
import static org.junit.jupiter.api.Assertions.assertFalse;
2120
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -215,7 +214,7 @@ public void testClientErrorAndRetriesTraced() {
215214
assertEquals(
216215
"java.net.UnknownHostException", attrs.get(BigQueryTelemetryTracer.EXCEPTION_TYPE));
217216
assertEquals(
218-
ErrorType.CLIENT_CONNECTION_ERROR.toString(),
217+
"CLIENT_CONNECTION_ERROR",
219218
attrs.get(BigQueryTelemetryTracer.ERROR_TYPE));
220219
assertEquals(
221220
"UnknownHostException: invalid-host-name-12345.com",

0 commit comments

Comments
 (0)