Merge branch 'main' into changePreToPost

Author: sofisl

.github/ISSUE_TEMPLATE/bug_report.md

@@ -6,46 +6,119 @@ about: Create a report to help us improve
 
 Thanks for stopping by to let us know something could be better!
 
-**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response.
+**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response. We try to review GitHub issues on a regular basis, however we cannot guarantee an SLO.
 
-Please run down the following list and make sure you've tried the usual "quick fixes":
+Before creating this issue, please run down the following list and make sure you've tried the usual "quick fixes":
 
   - Search the issues already opened: https://github.com/googleapis/google-cloud-java/issues
   - Check for answers on StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform
+  - Refer to the [Google Cloud Java Getting Started guides](https://docs.cloud.google.com/java/getting-started) for common usage patterns and troubleshooting.
+  - Verify you are using the latest versions of the Java SDK. If not, is it possible to upgrade? We recommend using the [Libraries-Bom](https://cloud.google.com/java/docs/bom) to manage dependency versions.
 
-If you are still having issues, please include as much information as possible:
+To help expedite the resolution of the issue, please fill out as much information as possible. If unable to provide information, please note down why the information is unable to be provided.
 
-#### Environment details
+## Issue Details
 
-1. Specify the API at the beginning of the title. For example, "[vision]: ...").
-   General, Core, and Other are also allowed as types
-2. OS type and version:
-3. Java version:
-4. Version(s):
+Required: Provide a detailed description of the issue. Any additional information helps with figuring out the issue.
 
-#### Steps to reproduce
+### Example
+I am seeing {ISSUE} when running X, Y... after doing Z. This behavior started after the X library upgrade a few weeks ago ...
 
-  1. ?
-  2. ?
+## Environment
 
-#### Code example
+Required: Provide details about your environment. If relevant, please also provide details about your GCP environment. The environment details MUST be filled out.
 
-```java
-// example
+Provide the relevant details about your environment:
+
+  - OS Type and Version:
+  - Java Version and JDK Vendor:
+  - (If using GraalVM) GraalVM Version:
+
+(Optional) If deployed on GCP, provide the relevant details about your GCP deployment environment:
+
+  - Project ID:
+  - Cloud Services:
+  - Deployment Environment (Compute, GKE, Run, etc):
+
+## Dependencies
+
+Required: Provide a list of the dependencies that are being used. If unable to provide the list, please list the relevant libraries shown below. One of the two sections below MUST be filled out.
+
+1. List your application’s dependency versions. Please provide the output of `mvn dependency:tree`, `gradle dependencies`, or your build system.
+
+### Example `mvn dependency:tree` output
 ```
+maven-dependency-plugin:tree
+
+- com.google.cloud:{X}:{Y}
+
+- com.google.auth:{X}:{Y}
+
+...
+```
+
+2. Provide the versions of the relevant libraries:
+    - Libraries-Bom ([com.google.cloud:libraries-bom](https://central.sonatype.com/artifact/com.google.cloud/libraries-bom)):
+      - (If not using Libraries-Bom) Client Libraries:
+    - Gax (gax / gax-grpc / gax-httpjson):
+    - Auth (google-auth-library-oauth2-http / google-auth-library-credentials):
+    - Any other relevant Java SDK dependencies:
+      - Google-Http-Java-Client ([com.google.http-client:google-http-client](https://central.sonatype.com/artifact/com.google.http-client/google-http-client)):
+
+## Reproducer
+
+Required: Provide a reproducer and the steps needed to reproduce this issue locally. If unable to provide a reproducer, please provide code snippets to help reproduce the issue. One of the two sections below MUST be filled out.
 
-#### Stack trace
+1. A reproducer is the quickest method to resolve this issue. It could be a test case or a sample application. It is easier for us to troubleshoot the problem and to verify the solution.
+
+Steps to reproduce:
+
+### Example
+1. Enable Speech API
+2. Upload a .mp4 file to GCS
+3. ...
+4. See {ERROR}
+
+If unable to provide a reproducer, please provide a reason: ...
+
+2. Provide as many code snippets as possible:
+
+### Example
+```java
+try (InstancesClient instancesClient = InstancesClient.create()) {
+  ...
+}
 ```
-Any relevant stacktrace here.
+
+## Logs and Stack Trace
+
+Required: Provide logs that showcase the error. This will help show the flow of the application and help narrow down the cause. Additionally, provide a stack trace of the error if possible.
+
+The Java SDK has a troubleshooting [guide](https://github.com/googleapis/google-cloud-java/blob/main/TROUBLESHOOTING.md) for enabling logs. This contains information regarding client-server communication, request and response details, and logging in dependency libraries. If using this guide, please obfuscate any private information (bearer tokens, request and response params, etc).
+
+Additionally, please provide a stack trace of the error seen:
+
+### Example
 ```
+TransportContext.java:347|Fatal (CERTIFICATE_UNKNOWN): PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target (
+
+"throwable" : {
 
-#### External references such as API reference guides
+sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
 
-- ?
+	at sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:456)
+
+	at sun.security.validator.PKIXValidator.engineValidate(PKIXValidator.java:323)
+
+...
+```
 
-#### Any additional information below
+## Behavior
 
+Optional: Any additional information about the behavior of the error is helpful to debug.
 
-Following these steps guarantees the quickest resolution possible.
+Behavioral Questions:
 
-Thanks!
+  - When did the issue begin? Is this behavior related to any dependency version upgrade?
+  - Is this behavior flaky? Or is this consistently seen in production?
+  - Is this behavior related to the volume of data?

.github/workflows/ci.yaml

@@ -56,62 +56,71 @@ jobs:
   units:
     runs-on: ubuntu-latest
     needs: bulk-filter
-    if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
     strategy:
       fail-fast: false
       matrix:
         java: [11, 17, 21, 25]
     steps:
     - name: Get current week within the year
       id: date
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
       run: echo "::set-output name=week_of_year::$(date +'%W' --utc)"
     - uses: actions/checkout@v4
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
     - uses: actions/setup-java@v4
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
       with:
         distribution: temurin
         java-version: ${{matrix.java}}
     - run: java -version
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
     - uses: actions/cache@v4
       id: mvn-cache
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
       with:
         path: ~/.m2/repository
         key: ${{ runner.os }}-maven-unified-${{ steps.date.outputs.week_of_year }}
     - run: .kokoro/build.sh
-      if: ${{ needs.bulk-filter.outputs.src == 'true' || needs.bulk-filter.outputs.ci == 'true' }}
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' && (needs.bulk-filter.outputs.src == 'true' || needs.bulk-filter.outputs.ci == 'true') }}
       env:
         JOB_TYPE: test
         JOB_NAME: units-${{matrix.java}}
   units-8-runtime:
     runs-on: ubuntu-latest
     needs: bulk-filter
-    if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
     name: "units (8)"
     steps:
     - name: Get current week within the year
       id: date
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
       run: echo "::set-output name=week_of_year::$(date +'%W' --utc)"
     - uses: actions/checkout@v4
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
     - uses: actions/setup-java@v4
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
       with:
         java-version: 8
         distribution: temurin
     - name: "Set jvm system property environment variable for surefire plugin (unit tests)"
       # Maven surefire plugin (unit tests) allows us to specify JVM to run the tests.
       # https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#jvm
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
       run: echo "SUREFIRE_JVM_OPT=-Djvm=${JAVA_HOME}/bin/java" >> $GITHUB_ENV
       shell: bash    
     - uses: actions/setup-java@v4
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
       with:
         java-version: 11
         distribution: temurin
         cache: maven
     - uses: actions/cache@v4
       id: mvn-cache
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' }}
       with:
         path: ~/.m2/repository
         key: ${{ runner.os }}-maven-unified-${{ steps.date.outputs.week_of_year }}
     - run: .kokoro/build.sh
-      if: ${{ needs.bulk-filter.outputs.src == 'true' || needs.bulk-filter.outputs.ci == 'true' }}
+      if: ${{ needs.bulk-filter.outputs.runnable == 'true' && (needs.bulk-filter.outputs.src == 'true' || needs.bulk-filter.outputs.ci == 'true') }}
       shell: bash      
       env:
         JOB_TYPE: test

.github/workflows/generated_files_sync.yaml

@@ -17,7 +17,7 @@ on:
   pull_request:
 name: generation diff
 env:
-  library_generation_image_tag: 2.73.0-SNAPSHOT  # {x-version-update:gapic-generator-java:current}
+  library_generation_image_tag: 2.73.0  # {x-version-update:gapic-generator-java:current}
 jobs:
   root-pom:
     # root pom.xml does not have diff from generated one

.github/workflows/hermetic_library_generation.yaml

@@ -21,7 +21,7 @@ env:
   REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }}
   GITHUB_REPOSITORY: ${{ github.repository }}
   # {x-version-update-start:gapic-generator-java:current}
-  GENERATOR_VERSION: 2.73.0-SNAPSHOT
+  GENERATOR_VERSION: 2.73.0
   # {x-version-update-end}
 jobs:
   library_generation:

.github/workflows/sdk-platform-java-downstream_protobuf_compatibility_check_nightly.yaml

@@ -27,13 +27,10 @@ jobs:
       fail-fast: false
       matrix:
         repo:
-          - java-bigtable
-          - java-firestore
-          - java-pubsub
           - java-pubsublite
         # Default Protobuf-Java versions to use are specified here. Without this, the nightly workflow won't know
         # which values to use and would resolve to ''.
-        protobuf-version: ${{ fromJSON(format('[{0}]', inputs.protobuf_runtime_versions || '"4.33.5"')) }}
+        protobuf-version: ${{ fromJSON(format('[{0}]', inputs.protobuf_runtime_versions || '"4.35.0"')) }}
     steps:
       - name: Checkout sdk-platform-java repo
         uses: actions/checkout@v4

.github/workflows/showcase-version-check.yaml

@@ -0,0 +1,96 @@
+# Copyright 2026 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Showcase Version Check
+
+on:
+  schedule:
+    - cron: '30 3 * * *' # Run daily at 3:30 AM UTC
+  workflow_dispatch: # Allow manual trigger
+  pull_request:
+    paths:
+      - 'librarian.yaml'
+      - 'java-showcase/gapic-showcase/pom.xml'
+      - '.github/workflows/showcase-version-check.yaml'
+
+jobs:
+  check-version:
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+    steps:
+      - uses: actions/checkout@v4
+      - name: Extract showcase version from pom.xml
+        id: extract_version
+        shell: bash
+        run: |
+          version=$(awk -F'[<>]' '/gapic-showcase.version/{print $3; exit}' java-showcase/gapic-showcase/pom.xml)
+          echo "version=$version" >> "$GITHUB_OUTPUT"
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.24'
+      - name: Extract showcase commit from librarian.yaml
+        id: extract_commit
+        shell: bash
+        run: |
+          version=$(go run github.com/googleapis/librarian/cmd/librarian@latest config get version)
+          commit=$(go run "github.com/googleapis/librarian/cmd/librarian@${version}" config get sources.showcase.commit)
+          echo "commit=$commit" >> "$GITHUB_OUTPUT"
+      - name: Verify showcase version and commit match
+        shell: bash
+        run: |
+          # 1. Query the remote repository for the specific version tag
+          REMOTE_URL="https://github.com/googleapis/gapic-showcase.git"
+          TAG_NAME="v${{ steps.extract_version.outputs.version }}"
+          
+          OUTPUT=$(git ls-remote "$REMOTE_URL" "refs/tags/$TAG_NAME")
+          
+          if [ -z "$OUTPUT" ]; then
+            echo "Error: Tag $TAG_NAME not found on remote $REMOTE_URL"
+            exit 1
+          fi
+          
+          # 2. Grab the commit hash from the very last line of the output
+          EXPECTED_COMMIT=$(echo "$OUTPUT" | tail -n 1 | awk '{print $1}')
+          
+          echo "Expected commit for tag $TAG_NAME: $EXPECTED_COMMIT"
+          echo "Current librarian commit: ${{ steps.extract_commit.outputs.commit }}"
+          
+          # 3. Cross-reference with librarian.yaml
+          if [ "${{ steps.extract_commit.outputs.commit }}" != "$EXPECTED_COMMIT" ]; then
+            echo "Mismatch: librarian.yaml has commit '${{ steps.extract_commit.outputs.commit }}', but tag '$TAG_NAME' is at commit '$EXPECTED_COMMIT'"
+            echo "MISMATCH=true" >> "$GITHUB_ENV"
+            exit 2
+          fi
+          
+          echo "Showcase version and commit are in sync!"
+      - name: Create issue on mismatch
+        if: failure() && env.MISMATCH == 'true'
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh issue create \
+            -R "${{ github.repository }}" \
+            -t "Showcase Version Mismatch: librarian.yaml and pom.xml out of sync" \
+            -b "The Showcase version in java-showcase/gapic-showcase/pom.xml and the commit in librarian.yaml do not match. Please update them to match. See logs: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
+      - name: Create issue on workflow failure
+        if: failure() && env.MISMATCH != 'true'
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh issue create \
+            -R "${{ github.repository }}" \
+            -t "Showcase Version Check Workflow Failure" \
+            -b "The Showcase Version Check workflow has failed due to an unexpected execution error. Please check the logs at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} for details."