Skip to content

Commit 931d211

Browse files
committed
chore: address review feedback from gemini code assist
1 parent 94a0068 commit 931d211

4 files changed

Lines changed: 7 additions & 12 deletions

File tree

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@
2020
/java-bigtable/ @googleapis/bigtable-team @googleapis/cloud-sdk-java-team @googleapis/cloud-sdk-librarian-team
2121
/java-firestore/ @googleapis/firestore-team @googleapis/cloud-sdk-java-team @googleapis/cloud-sdk-librarian-team
2222
/librarian.yaml @googleapis/cloud-sdk-java-team @googleapis/cloud-sdk-librarian-team
23-
/java-shared-config/ @googleapis/cloud-sdk-java-team @googleapis/cloud-sdk-java-team
23+
/java-shared-config/ @googleapis/cloud-sdk-java-team @googleapis/cloud-sdk-librarian-team

generation/apply_versions.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ elif [[ "$column_name" != "current" ]]; then
3131
fi
3232

3333

34-
SED_SCRIPT_FILE=$(mktemp)
34+
SED_SCRIPT_FILE=$(mktemp) || exit 1
3535
trap 'rm -f "$SED_SCRIPT_FILE"' EXIT
3636

3737
# The second column is

java-shared-config/java-shared-config/pom.xml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -144,17 +144,13 @@
144144
<version>3.8.1</version>
145145
<configuration>
146146
<ignoredUnusedDeclaredDependencies>
147-
<ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api
148-
</ignoredUnusedDeclaredDependency>
147+
<ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency>
149148
</ignoredUnusedDeclaredDependencies>
150149
<!-- TODO: Try to remove these exclusions by updating handwritten libs -->
151150
<ignoredNonTestScopedDependencies>
152-
<ignoredNonTestScopedDependency>io.grpc:*
153-
</ignoredNonTestScopedDependency>
154-
<ignoredNonTestScopedDependency>com.google.protobuf:*
155-
</ignoredNonTestScopedDependency>
156-
<ignoredNonTestScopedDependency>com.google.api.grpc:*
157-
</ignoredNonTestScopedDependency>
151+
<ignoredNonTestScopedDependency>io.grpc:*</ignoredNonTestScopedDependency>
152+
<ignoredNonTestScopedDependency>com.google.protobuf:*</ignoredNonTestScopedDependency>
153+
<ignoredNonTestScopedDependency>com.google.api.grpc:*</ignoredNonTestScopedDependency>
158154
</ignoredNonTestScopedDependencies>
159155
</configuration>
160156
</plugin>

java-shared-config/native-image-shared-config/pom.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
</organization>
2929
<scm>
3030
<connection>scm:git:git@github.com:googleapis/java-shared-config.git</connection>
31-
<developerConnection>scm:git:git@github.com:googleapis/java-shared-config.git
32-
</developerConnection>
31+
<developerConnection>scm:git:git@github.com:googleapis/java-shared-config.git</developerConnection>
3332
<url>https://github.com/googleapis/java-shared-config</url>
3433
<tag>HEAD</tag>
3534
</scm>

0 commit comments

Comments
 (0)